fix(cli): render the provision command as a YAML block scalar - #220
Open
cdotta wants to merge 1 commit into
Open
fix(cli): render the provision command as a YAML block scalar#220cdotta wants to merge 1 commit into
cdotta wants to merge 1 commit into
Conversation
javiertoledo
self-requested a review
August 31, 2026 18:28
facility-crew.yml and facility-codex.yml were unparseable on any repository where init detected no provision command, so neither agent trigger ran: facility-crew.yml:196:27: could not parse as YAML: mapping values are not allowed in this context [syntax-check] The command is interpolated into a bare scalar, and the no-provision fallback text contains "facility: ". Any provision command containing ": " breaks the same way, e.g. 'docker compose up -d && echo "db: ready"'. Rendered into a block scalar, matching what checksRun already does for the checks list. Message text is unchanged; only its YAML context is. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
javiertoledo
force-pushed
the
fix/provision-block-scalar
branch
from
August 31, 2026 18:28
b114e50 to
4890d90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes part of #217.
facility-crew.ymlandfacility-codex.ymlare unparseable on any repository whereinitdetects no provision command, so neither agent trigger ever runs:The command is interpolated into a bare scalar (
run: {{PROVISION_CMD}}), and the no-provision fallback text containsfacility:. The colon-space ends the scalar.This is not limited to the fallback — any provision command containing
": "breaks identically:Change
Render the command into a block scalar, matching what
checksRunalready does for the checks list — including for strings containing::error::. The message text is unchanged; only its YAML context is.Verification
actionlinton both rendered templates across three cases: no provision command, a command containing": ", and an ordinary command. Clean in all three; the first two fail onmain.node guards/run.mjsclean.Deliberately not included
Having
doctorparse the workflows it generated would have caught this, and would close the whole class rather than this instance —doctor --run-guardscurrently reports "Everything checkable checks out" on a repository whose primary workflow cannot be parsed. That is a larger change and I would rather agree the approach first. Detail in #217.