fix(toolchain): align the engines floor and quickstart with what actually runs - #246
fix(toolchain): align the engines floor and quickstart with what actually runs#246ophiocus wants to merge 2 commits into
Conversation
…ally runs engines said ">=22" while the pinned pnpm@11 hard-requires node:sqlite, which is unflagged only from 22.13.0 / 23.4.0 - so an engines-compliant Node 23.3 died inside pnpm's bundle before install (theam#240's four-rung ladder). The range now names the real floor. The quickstarts replace "corepack enable" with "npm install -g pnpm@11": corepack is no longer bundled from Node 25, and the npm route works on every supported release (theam#167, following the reporter's own suggestion), with corepack kept as a documented alternative on 22-24. Closes theam#240 Closes theam#167 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
adrian-lorenzo
left a comment
adrian-lorenzo
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
The pnpm and Corepack diagnosis is correct. We’re standardizing the repository on Node 24 LTS, so please simplify the root engine requirement to ^24.0.0 and update the quickstart to recommend Node 24 LTS. The pnpm installation correction can remain as part of this PR.
With that small adjustment, this should be ready.
engines simplifies to ^24.0.0 and the quickstart recommends Node 24 LTS; the pnpm-over-corepack install correction stays. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Done in a5a5a9f — engines is |
|
Closing this one with a smile: 8889753 on main does everything this PR set out to do and goes further — and I'm glad to see the |
2 participants
The toolchain-floor pair: two setup bugs, one truth. Closes #240, closes #167 — and #167's fix follows @elirethDev's own suggested wording; thanks for the clean report and the reproduction on Node 26.
engines now names the floor the pinned
pnpm@11actually needs:>=22.13.0 <23.0.0 || >=23.4.0. pnpm 11 hard-requiresnode:sqlite, unflagged exactly at 22.13.0 / 23.4.0 (nodejs/node@55239a4) — #240 documents the four cryptic failures an engines-compliant Node 23.3 walks into today.Quickstarts (README ×2, CONTRIBUTING) replace
corepack enablewithnpm install -g pnpm@11, which works on every supported release; corepack — unbundled from Node 25 (#167) — stays as a documented alternative for 22–24.Deliberately not included: a
preinstallprobe fornode:sqlite. It would run in every image build and CI path for marginal gain once engines tells the truth — happy to add one if you'd rather have the belt.Verified:
pnpm install --frozen-lockfileand guards green under the new range on Node 22.23.2 (Linux and Windows); the range excludes exactly the versions proven broken in #240 (20.18, 23.3) and admits the proven-working ones.