Skip to content

ST 960 Fix - Spacious theme depreciation warnings #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jenisha00 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ST 960 Fix - Spacious theme depreciation warnings #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27c3a5c
fix: deprecated wp_script_add_data() conditional notice on wp 6.9+
Aug 4, 2026
68cf169
fix: deprecated hexdec() notice when primary color uses alpha
Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion inc/enqueue-scripts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,11 @@ function spacious_scripts_styles_method() {
wp_enqueue_script( 'spacious-custom', SPACIOUS_JS_URL . '/spacious-custom.js', array( 'jquery' ) );

wp_enqueue_script( 'html5', SPACIOUS_JS_URL . '/html5shiv.min.js', true );
wp_script_add_data( 'html5', 'conditional', 'lte IE 8' );
// The 'conditional' data key is deprecated since WP 6.9.0 and has no effect there;
// only set it on older versions to keep html5 restricted to IE8 and below.
if ( version_compare( $GLOBALS['wp_version'], '6.9', '<' ) ) {
wp_script_add_data( 'html5', 'conditional', 'lte IE 8' );
}
}

add_action( 'wp_enqueue_scripts', 'spacious_scripts_styles_method' );
Expand Down
24 changes: 21 additions & 3 deletions inc/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,11 +313,29 @@ function spacious_sidebar_select() {

/**
* Change hex code to RGB
* Source: https://css-tricks.com/snippets/php/convert-hex-to-rgb/#comment-1052011
*/
if ( ! function_exists( 'spacious_color_to_hex' ) ) {
/**
* Normalize a color value to a bare hex string.
*
* The primary color customizer control allows picking an alpha color, so the
* stored value can be an `rgba(r,g,b,a)` string rather than a hex string.
* hexdec() doesn't understand that format, so convert it to hex first.
*/
function spacious_color_to_hex( $color ) {
if ( preg_match( '/rgba?\(\s*(\d+)\s*,\s*(\d+)\s*,\s*(\d+)/i', $color, $matches ) ) {
return str_pad( dechex( (int) $matches[1] ), 2, '0', STR_PAD_LEFT )
. str_pad( dechex( (int) $matches[2] ), 2, '0', STR_PAD_LEFT )
. str_pad( dechex( (int) $matches[3] ), 2, '0', STR_PAD_LEFT );
}

return str_replace( '#', '', $color );
}
}

if ( ! function_exists( 'spacious_hex2rgb' ) ) {
function spacious_hex2rgb( $hexstr ) {
$int = hexdec( str_replace( '#', '', $hexstr ) );
$int = hexdec( spacious_color_to_hex( $hexstr ) );

$rgb = array( "red" => 0xFF & ( $int >> 0x10 ), "green" => 0xFF & ( $int >> 0x8 ), "blue" => 0xFF & $int );
$r = $rgb['red'];
Expand All @@ -337,7 +355,7 @@ function spacious_darkcolor( $hex, $steps ) {
$steps = max( -255, min( 255, $steps ) );

// Normalize into a six character long hex string
$hex = str_replace( '#', '', $hex );
$hex = spacious_color_to_hex( $hex );
if ( strlen( $hex ) == 3 ) {
$hex = str_repeat( substr( $hex, 0, 1 ), 2 ) . str_repeat( substr( $hex, 1, 1 ), 2 ) . str_repeat( substr( $hex, 2, 1 ), 2 );
}
Expand Down