Better mobile compatibility by using different pointer API when supported - #102
Better mobile compatibility by using different pointer API when supported#102mclaire-dev wants to merge 3 commits into
Conversation
…moved vscode formatting
| } | ||
| window.removeEventListener("resize", onWindowResize); | ||
| }; | ||
| window.addEventListener("resize", onWindowResize); |
There was a problem hiding this comment.
Still want to be removing here right?
There was a problem hiding this comment.
I have been basing this off of the rainbowCursor file and in the rainbowCursor there is an addEventListener method in destroy()
There was a problem hiding this comment.
Ahh, haha, probably my mistake in that one spreading out 👯
There was a problem hiding this comment.
Coming along well though, open out of draft when you're ready. Don't worry too much about formatting, I think I should run a script after this to balance it all out across all files :)
There was a problem hiding this comment.
hi thats awesome. ill start working on it again starting tomorrow.
id like to add that the compatibility check is because pointermove and pointerenter were added 6 years ago in 2020 and I'm not sure how far back you want this essential function of the library to go in compatibility.
2 participants
Addresses #48
This is my first pull request and I did use Format Document in VSCode(sorry) so I apologize if it's not the best pull request.
It works in my testing though.