Repository navigation
Kill adb logcat process on test cleanup - #43
Merged
Merged
Conversation
The integration test spawned 'adb logcat' and stored the Child in an underscore-prefixed binding that was dropped without kill or wait, so dropping the Child did not terminate the process and orphaned logcat processes could accumulate across runs. Wrap the Child in a guard that kills and waits on drop, covering both normal completion and panic. Fixes #36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36.
The Android integration test spawned
adb logcatand stored theChildin an underscore-prefixed binding that was dropped withoutkillorwait, so the logcat process was left running. Wrap the child in a guard that kills and waits on drop, covering both normal completion and panic.