Conversation
jayfshrimpton
left a comment
There was a problem hiding this comment.
Reviewed bfe295a.
Dead Whenever config/schedule.rb is removed, schedule.yml documents Sidekiq-cron / .ci-setup/crontab ownership, and the new test covers that. Active cron entries untouched. Author’s focused test pass looks fine.
Non-blocking: title says feat(mail) but this is BGW-32 scheduler cleanup.
No blocking issue from this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the dead Whenever scheduler configuration referenced by BGW-32. The Whenever gem is not installed, and the configured
db:update_temporaltask does not exist.Changes
config/schedule.rb.config/schedule.ymldocumenting that Sidekiq-cron owns in-process scheduled jobs and.ci-setup/crontabowns the container rake schedule.test/config/scheduler_configuration_test.rbto verify that the dead scheduler is absent and both scheduler owners are documented.Testing
Test file:
test/config/scheduler_configuration_test.rbCommand run inside the API development container:
bundle exec rails test test/config/scheduler_configuration_test.rbBefore the fix:
2 runs, 3 assertions, 2 failures, 0 errorsAfter the fix:
2 runs, 5 assertions, 0 failures, 0 errorsAdditional checks:
wheneveris not present inGemfileorGemfile.lock.update_temporalis not present in Ruby or Rake files.git diff --checkpassed.API boot OK.Build Combination
feat/bgw-32atbfe295a11e7e69611095ab354597799b522dcc234eab6935b08b6d1e6c9868a6472e24ca5276bbe4510.0.xatdd562afc757f426ac8005676e6f2f9814d71cbbfTest Scope
The test verifies removal of the dead Whenever schedule and documents both scheduler owners; it does not execute every existing Sidekiq-cron job or container cron command.
Evidence
Before-and-after test output and configuration-check screenshots are attached below.