Skip to content

feat(confing): dead scheduler config: config/schedule.rb points the whenever gem at a rake task that does not exist - #116

Open
Reem-997 wants to merge 1 commit into
thoth-tech:11.0.xfrom
Reem-997:feat/bgw-32
Open

Reem-997 wants to merge 1 commit into
thoth-tech:11.0.xfrom
Reem-997:feat/bgw-32

Conversation

@Reem-997

Copy link
Copy Markdown

Description

Removes the dead Whenever scheduler configuration referenced by BGW-32. The Whenever gem is not installed, and the configured db:update_temporal task does not exist.

Changes

  • Deleted config/schedule.rb.
  • Added a comment to config/schedule.yml documenting that Sidekiq-cron owns in-process scheduled jobs and .ci-setup/crontab owns the container rake schedule.
  • Added test/config/scheduler_configuration_test.rb to verify that the dead scheduler is absent and both scheduler owners are documented.
  • Left the two active scheduler configurations unchanged.

Testing

Test file:

test/config/scheduler_configuration_test.rb

Command run inside the API development container:

bundle exec rails test test/config/scheduler_configuration_test.rb

Before the fix:

2 runs, 3 assertions, 2 failures, 0 errors

After the fix:

2 runs, 5 assertions, 0 failures, 0 errors

Additional checks:

  • whenever is not present in Gemfile or Gemfile.lock.
  • update_temporal is not present in Ruby or Rake files.
  • git diff --check passed.
  • API boot check passed with API boot OK.

Build Combination

  • API: feat/bgw-32 at bfe295a11e7e69611095ab354597799b522dcc23
  • Web: detached HEAD at 4eab6935b08b6d1e6c9868a6472e24ca5276bbe45
  • Deploy: 10.0.x at dd562afc757f426ac8005676e6f2f9814d71cbbf

Test Scope

The test verifies removal of the dead Whenever schedule and documents both scheduler owners; it does not execute every existing Sidekiq-cron job or container cron command.

Evidence

Before-and-after test output and configuration-check screenshots are attached below.

Before Fix – Minitest Failure After Fix – Minitest Pass Required Configuration Checks API Boot and Final File Scope

@jayfshrimpton jayfshrimpton left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed bfe295a.

Dead Whenever config/schedule.rb is removed, schedule.yml documents Sidekiq-cron / .ci-setup/crontab ownership, and the new test covers that. Active cron entries untouched. Author’s focused test pass looks fine.

Non-blocking: title says feat(mail) but this is BGW-32 scheduler cleanup.

No blocking issue from this review.

@Reem-997 Reem-997 changed the title feat(mail): dead scheduler config: config/schedule.rb points the whenever gem at a rake task that does not exist feat(confing): dead scheduler config: config/schedule.rb points the whenever gem at a rake task that does not exist Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants