Conversation
Updated the Pull Request template to include new sections for Jira ticket, summary, testing, security, and evidence.
…uest-template Revise Pull Request template structure and content
Author
|
Opened against the wrong repo (thoth-tech instead of ontrack-features-t2-2026), closing and reopening correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two empty states (the task comments panel when a task has no comments, and
the staff inbox list when filters match zero tasks) each rendered a single
mat-icon with aria-hidden="true" applied by MatIcon itself, and no
accompanying text. This left screen reader users with no way to distinguish
an empty state from a failed load. Added visible text next to each icon and
explicitly marked both icons decorative, following the text-only pattern
already used in notifications-page.component.html:46-52.
Fixes A11Y-SR04
Type of change
Branch/commit combo
How Has This Been Tested?
Added vitest cases to task-comments-viewer.component.spec.ts and
staff-task-list.component.spec.ts covering both the empty-state-rendered and
non-empty (no-render) paths for each component. Run via:
npx ng test --include=src/app/tasks/task-comments-viewer/task-comments-viewer.component.spec.ts --include=src/app/units/states/tasks/inbox/directives/staff-task-list/staff-task-list.component.spec.ts --watch=false
Result: 2 test files, 6 tests, all passing.
The task-comments-viewer empty state was also manually reproduced and
confirmed in-browser (logged in as a student, opened a task with zero
comments). The staff-task-list empty state could not be manually reproduced
in-browser, since no seeded fixture tutor account had any tasks assigned to
filter down from verified instead via code inspection and the component
test, using a template override of the exact fixed markup (see note below).
Note: this fix touched two components, so two spec files were run rather
than the single file the card describes.
Not covered: real screen-reader announcement behaviour (VoiceOver/NVDA)
wasn't manually verified — only that the accessible text node exists/is
visible in the DOM. Both spec files test the empty-state markup via a
template override (a copied snippet of the fixed block) rather than
rendering each component's full real template, since the full templates
require additional Angular Material modules (MatMenuModule, CDK virtual
scroll, and others) and extensive service mocking out of scope for this
a11y-focused fix.
Testing Checklist: