FIX: Download issues with text and audio - #174
Open
connorclancydev wants to merge 1 commit into
Open
connorclancydev wants to merge 1 commit into
connorclancydev wants to merge 1 commit into
Conversation
fixes the errors with test audio and text that stop the downloads from working properly by updating missing links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the errors with test audio and text that stop the downloads from working properly by updating missing links
Description
There was a report that audio, text and bitmap downloads were not functioning properly, this PR solves all those issues and makes the MSYS match the WSL by fixing broken hyperlinks and adjusting the code to suit the new hyperlinks, originally errors would run in the tests for audio, text and windows now the only warning is the intentional warnings that are there for testing purposes
Type of change
How Has This Been Tested?
so to test this you have to install a environment for WSL and MSYS preferably to test both but either should work. Then you will proceed to open the test application in terminal and select the following tests 1 audio, 13 text and 15 windows. to see they work all should work without throwing any errors that arent intentional. errors that are intentional have a message before them saying they are intentional. If testing both WSL and MSYS make sure that you install individual splashkits for each
Testing Checklist
Checklist