Repository navigation
Conversation
✅ Deploy Preview for splashkit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new step to the contribution guide (
CONTRIBUTE.md) explaining how to review other contributors' pull requests locally.The new step 11, Review Other Pull Requests Locally, covers:
upstreamremote (one-time setup)git fetch upstream pull/<PR_NUMBER>/head:pr-<PR_NUMBER>This makes it easier for team members to properly test peer PRs (e.g. running usage examples) instead of only reading the diff on GitHub.
Type of change
How Has This Been Tested?
The steps were tested end to end on a real peer pull request (#871):
git fetch upstream pull/871/head:pr-871pr-871and verified the PR's files appeared locallygit branch -D pr-871and confirmed my own branches and uncommitted work were unaffectedTesting Checklist
Checklist
If involving code
Folders and Files Added/Modified
CONTRIBUTE.mdAdditional Notes
The new step follows the same format as the existing steps in the guide (bold heading, bullet points, and
shellcode blocks).