[SCAL-323294] changes for fetch_data tool by saharsh-ts · Pull Request #179 · thoughtspot/mcp-server

saharsh-ts · 2026-07-09T15:49:58Z

No description provided.

gemini-code-assist

Code Review

This pull request introduces two new tools, search_objects and fetch_data, to the MCP server for searching and retrieving data from ThoughtSpot objects (Answers and Liveboards). It includes new schemas, gRPC-backed API clients, terminology mapping for synonyms, and comprehensive unit tests. The reviewer identified a critical issue in src/servers/mcp-server.ts where the asynchronous validateConnection method is not awaited in the Ping tool case, causing the check to always evaluate to true.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-07-09T15:53:17Z

 			case ToolName.Ping: {
 				if (this.ctx.props.accessToken && this.ctx.props.instanceUrl) {
-						if (!this.getThoughtSpotService(recorder).validateConnection()) {
+					if (!this.getThoughtSpotService(recorder).validateConnection()) {


The validateConnection method is asynchronous and returns a Promise<boolean>. Since it is not awaited here, the condition !promise will always evaluate to false because any Promise object is truthy. This effectively bypasses the connection validation check. Please add await to correctly evaluate the promise result.

Suggested change

if (!this.getThoughtSpotService(recorder).validateConnection()) {

if (!(await this.getThoughtSpotService(recorder).validateConnection())) {

References

When a method returns a Promise, ensure it is awaited to prevent race conditions and potential data loss, especially when subsequent operations depend on its completion.

added await

mouryabalabhadra · 2026-07-16T04:40:31Z

@copilot review the pr

Copilot · 2026-07-16T04:48:39Z

@copilot review the pr

Reviewed the PR and addressed one issue: fetch_data now rejects empty visualization_ids instead of treating it as “fetch all”. Added validation coverage in tests as well. Fixed in commit 352f265.

saharsh-ts · 2026-07-16T13:11:10Z

@copilot review the pr

Rifdhan · 2026-07-22T00:21:13Z

+		),
+	columns: z.array(z.string()).describe("The column names, in order."),
+	data_rows: z
+		.array(z.array(z.unknown()))


Is there a way to add a proper type contract

Tightened to string | number | boolean | null datatypes.

Rifdhan · 2026-07-22T00:23:50Z

+
+// Round numeric cells to 2 decimals: collapses FP noise and trims payload.
+// Non-numbers and non-finite values pass through untouched.
+function roundCell(value: unknown): unknown {


This seems arbitrary, what if the customer wants more precision? I feel we should return the full value for now, and not prematurely optimize this.

Removed — cells now returned at full precision.

Rifdhan · 2026-07-22T00:29:44Z

+		// treats it as "must hold the whole viz" and 500s when it's too small.
+		// Start at maxRows; on that error, bump to the required count and refetch,
+		// then cap rows client-side below. Attempts are bounded (a full Liveboard
+		// can report a larger viz on each retry) to avoid a runaway loop.


This seems like a hacky design, we should make the API call such that it is successful on the first try. Is there no way to do that using this API?

Reworked to one call — Answers pass record_size = max_rows,
Liveboards request the max 32-bit int.
Verified on local instance.

saharsh-ts · 2026-08-06T04:10:01Z

@copilot review the PR

mouryabalabhadra · 2026-08-19T20:57:22Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces the get_object_data tool to fetch tabular data for saved Answers and Liveboards, gated by a new canDownloadData privilege check. It maps the REST v2 metadata endpoints, normalizes data formats, and includes comprehensive integration and unit tests. Feedback recommends improving type safety in the catch block of callGetObjectData by verifying if the error is an instance of Error before accessing its message, and refactoring the supported object types into a shared constant to eliminate duplication between the Zod schema and the local enum.

cloudflare-workers-and-pages · 2026-08-22T08:39:02Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
✅ Deployment successful! View logs	rifdhan-test-app	`376bd4b`	Aug 27 2026, 08:34 AM

mouryabalabhadra · 2026-08-26T05:27:05Z

+
+// "Unbounded" record_size for Liveboards (they 500 if it can't hold the whole
+// viz). Max 32-bit signed int — the endpoint reads it as a GraphQL Int.
+export const LIVEBOARD_RECORD_SIZE = 2_147_483_647;


Liveboard fetches send record_size = 2,147,483,647 and apply max_rows only client-side, so the Worker downloads the entire result set of every visualization before slicing to 25 rows.

ack. The Liveboard /data endpoint 500s when record_size is below the viz's full row count, so it can't be bounded server-side — record_size is int32-max and max_rows caps client-side.

so we fetch complete liveboard vizzes, and then use min(numViz, 25) objects to explain the liveboard.

mouryabalabhadra · 2026-08-27T02:49:03Z

 		.optional()
 		.describe(
-			"Set only when this result is a specific visualization on a Liveboard: `object_id` is the Liveboard and this is the visualization. Pass it to fetch_data as `visualization_ids` to fetch just this viz.",
+			"Set only when this result is a specific visualization on a Liveboard: `object_id` is the Liveboard and this is the visualization. Pass it to get_object_data as `visualization_ids` to fetch just this viz.",


we are unconditionally instructing the model to call get_object_data but it sbehind privilege

mouryabalabhadra · 2026-08-27T02:50:38Z

+				`Fetched data for ${object_id} (${result.data.length} result(s))`,
+			);
+		} catch (error) {
+			// Surface the upstream message (e.g. status 401/500) so the failure is


this is too generic catch all error. 401 errors have the dispatch-layer 401 handler to return explicit reauthentication message

mouryabalabhadra · 2026-08-27T02:52:21Z

 	}

+	@WithSpan("call-get-object-data")
+	async callGetObjectData(


callGetObjectData checks canDownloadData() but doesn't wait for ensureSessionInfo()

it should do similar to listTools

added await this.ensureSessionInfo() before the gate, same as listTools

saharsh-ts added 2 commits July 9, 2026 11:52

[SCAL-319676] terminologies added

d7f8fbd

[SCAL-323294] changes for search_objects tool

57e354a

gemini-code-assist Bot reviewed Jul 9, 2026

View reviewed changes

[SCAL-323294] merge main and resolve conflicts

9396681

saharsh-ts force-pushed the SCAL-323294_fetch-data branch from 2b7918b to de4930a Compare July 13, 2026 07:47

Copilot started work on behalf of mouryabalabhadra July 16, 2026 04:40 View session

Copilot finished work on behalf of mouryabalabhadra July 16, 2026 04:49

Copilot AI requested a review from mouryabalabhadra July 16, 2026 04:49

saharsh-ts force-pushed the SCAL-323294_fetch-data branch from 352f265 to 6454d11 Compare July 16, 2026 05:14

[SCAL-323294] added schema for search_objects response format

959eeed

saharsh-ts force-pushed the SCAL-323294_fetch-data branch from 6454d11 to ddaf1fa Compare July 20, 2026 09:47

Rifdhan reviewed Jul 22, 2026

View reviewed changes

saharsh-ts added 2 commits July 22, 2026 14:07

[SCAL-323294] refactoring and updates to search-objects tool

09bd735

[SCAL-323294] fetch_data refactoring and updates

cb87e5c

saharsh-ts force-pushed the SCAL-323294_fetch-data branch from 349b5d8 to cb87e5c Compare July 22, 2026 08:45

saharsh-ts added 4 commits July 24, 2026 14:00

[SCAL-323294] added schema check for searhc_objects, and refactored

7fd9463

Merge branch 'SCAL-323294_search-objects' into SCAL-323294_fetch-data

1d9164f

[SCAL-323294] merge main

6e603fe

[SCAL-323294] updated on review comments

7488bc3

Rifdhan reviewed Aug 10, 2026

View reviewed changes

saharsh-ts added 5 commits August 11, 2026 08:40

Merge branch 'main' into SCAL-323294_fetch-data

33c01f9

[SCAL-323294] check for data download privileges

f9cc421

[SCAL-323294] update mcp-server-base.ts

8f19484

[SCAL-323294] updated tool definitions and on comments.

31e061b

[SCAL-323294] changed default values for canDownloadData

09b1cb0

Rifdhan reviewed Aug 18, 2026

View reviewed changes

Comment thread src/servers/tool-definitions.ts Outdated

Comment thread src/servers/tool-definitions.ts

Comment thread src/thoughtspot/fetch-data/fetch-data.ts Outdated

saharsh-ts added 2 commits August 19, 2026 13:43

[SCAL-323294] address comments

c2bf27c

[SCAL-323294] renamed fetch_data to get_object_data

0b49384

gemini-code-assist Bot reviewed Aug 19, 2026

View reviewed changes

Comment thread src/servers/mcp-server.ts Outdated

Comment thread src/thoughtspot/get-object-data/get-object-data.ts Outdated

[SCAL-323294] merge main, resolve conflict

28c4c56

saharsh-ts requested review from a team and mouryab as code owners August 22, 2026 08:38

[SCAL-323294] added enums

9dc4ea2

mouryabalabhadra reviewed Aug 26, 2026

View reviewed changes

mouryabalabhadra reviewed Aug 27, 2026

View reviewed changes

[SCAL-323294] updated on comments

376bd4b

	if (!this.getThoughtSpotService(recorder).validateConnection()) {
	if (!(await this.getThoughtSpotService(recorder).validateConnection())) {

Uh oh!

Conversation

saharsh-ts commented Jul 9, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mouryabalabhadra commented Jul 16, 2026

Uh oh!

Copilot AI commented Jul 16, 2026

Uh oh!

saharsh-ts commented Jul 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saharsh-ts commented Aug 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mouryabalabhadra commented Aug 19, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

cloudflare-workers-and-pages Bot commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Workers

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saharsh-ts Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mouryabalabhadra Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

cloudflare-workers-and-pages Bot commented Aug 22, 2026 •

edited

Loading

saharsh-ts Aug 27, 2026 •

edited

Loading

mouryabalabhadra Aug 27, 2026 •

edited

Loading