-
Notifications
You must be signed in to change notification settings - Fork 13
SCAL-321380: Add converter from EmbedEvent.FilterChanged payload to HostEvent.UpdateFilters #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
204847f
bd7da99
4a673b8
c89145d
0c175fa
241eed3
2f934e8
fbb7ff5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5875,6 +5875,10 @@ export enum HostEvent { | |
| * } | ||
| * }); | ||
| * ``` | ||
| * `columnName` and `operator` are also accepted as aliases for `column` | ||
|
Comment on lines
5875
to
+5878
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tag-ordering (style guide rule 1): this new paragraph about the |
||
| * and `oper` respectively. To reapply the filter state captured from | ||
| * {@link EmbedEvent.FilterChanged}, use `convertFilterChangedToUpdateFiltersPayload` | ||
| * to convert its payload into the shape expected here. | ||
| * @version SDK: 1.23.0 | ThoughtSpot: 9.4.0.cl | ||
| */ | ||
| UpdateFilters = 'updateFilters', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc comments here are published to developers.thoughtspot.com, and TypeDoc attaches a leading comment only to the declaration immediately below it — so
columnNameandoperator(the new alias properties) will render with no description at all, whilecolumn/operget one. Suggest giving the aliases their own (even one-line) doc comments.