SCAL-334772 Extract full-height support into a shared module

[shivam-kumar-ts]

What

The full-height feature was implemented twice, verbatim — once in LiveboardEmbed and once in AppEmbed. This PR extracts it into a single FullHeightController in src/full-height.ts, backed by a shared FullHeightViewConfig type, and deletes ~470 lines of duplication from the embed classes.

No change to the public API surface: fullHeight, minimumHeight, defaultHeight, lazyLoadingForFullHeight, lazyLoadingMargin and enableScrollableContainerLazyLoading are accepted by exactly the same embeds as before, with the same semantics.

Why

Both embeds carried identical copies of sendFullHeightLazyLoadData, requestVisibleEmbedCoordinatesHandler, updateIFrameHeight, embedIframeCenter, setIframeHeightForNonEmbedLiveboard, registerLazyLoadEvents and unregisterLazyLoadEvents, plus the same three state fields, the same constructor wiring and the same query-param block. The liveboardRelatedRoutes list was duplicated character-for-character. A third copy of the viewport math lived in TsEmbed.getIframeCenter().

Every fix to this feature had to land in two or three places, and the two copies had already drifted (AppEmbed silently ignored defaultHeight).

How

• src/full-height.ts (new) — FullHeightController owns all full-height state, event handlers, query params and listener lifecycle. It talks to the embed through a 4-method FullHeightEmbedHost contract (getIframe / setFrameHeight / on / trigger), so it needs nothing from the embed class hierarchy. Inert unless fullHeight is enabled.
• src/types.ts — FullHeightViewConfig holds the six full-height props; LiveboardViewConfig and AppViewConfig extend it and drop their duplicated declarations.
• src/utils.ts — calculateElementCenter(element) generalises the viewport math that was inlined in TsEmbed.
• src/embed/{app,liveboard}.ts — reduced to constructing the controller and forwarding four lifecycle calls.
• src/embed/ts-embed.ts — getIframeCenter() is now a thin delegate to calculateElementCenter.

The defaultHeight mutation that used to happen as a side effect of getEmbedParamsObject() is now a minimumHeight getter derived from the view config, removing the ordering dependency between param building and height events.

File
src/embed/app.ts	+19 / −226
src/embed/liveboard.ts	+26 / −248
src/embed/ts-embed.ts	+2 / −25
src/full-height.ts	+284 (new)
src/types.ts	+135
src/utils.ts	+38

Behavior change ⚠️

AppEmbed now honours defaultHeight. It previously resolved minimumHeight || 500 and ignored defaultHeight entirely; LiveboardEmbed resolved minimumHeight || defaultHeight || 500. The shared getter applies the Liveboard rule to both.

This is additive and non-breaking — passing defaultHeight to AppEmbed was a TypeScript excess-property error before, so no typed consumer can regress. minimumHeight still wins where both are set.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@641

commit: 5cd8bfd

[gemini-code-assist]

Code Review

This pull request refactors the full-height and lazy-loading logic for AppEmbed and LiveboardEmbed by extracting it into a new, dedicated FullHeightController class. This centralizes height negotiation, query parameter additions, and viewport listeners for lazy loading, improving code modularity and testability. Corresponding tests have been updated, and a new test suite src/full-height.spec.ts has been added. Additionally, the inline iframe center calculation in TsEmbed has been replaced with a helper function calculateElementCenter in utils.ts.

Feedback is provided regarding a style guide violation in src/types.ts, where the non-standard @type tag is used in TSDoc comments.

[shivam-kumar-ts]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors the full-height functionality for App and Liveboard embeds by introducing a dedicated FullHeightController class, centralizing the logic for height negotiation, lazy loading, and coordinate tracking. It also introduces a shared FullHeightViewConfig interface to improve type safety and maintainability. The review feedback includes several style guide enforcements regarding American English spelling and documentation tag formatting, as well as a defensive programming suggestion to verify coordinate availability before triggering events.

[gemini-code-assist]

Code Review

This pull request refactors the full-height and lazy-loading logic for AppEmbed and LiveboardEmbed by extracting it into a shared FullHeightController class, reducing code duplication. Feedback on the changes focuses on adhering to the repository style guide, specifically: correcting British English spellings ('behaviour', 'honours') to American English, moving imports to the top of the test file, and replacing invalid placeholder tags like <EmbedComponent> with concrete component names in JSDoc code examples to ensure syntactically valid TypeScript.

[gemini-code-assist]

Code Review

This pull request refactors the full-height and lazy-loading logic for AppEmbed and LiveboardEmbed by extracting it into a dedicated FullHeightController class, improving modularity and testability. The review feedback points out several style guide violations in src/types.ts regarding the spelling of 'behavior' and the formatting of the @Version tag to use 'ThoughtSpot Cloud'. Additionally, it recommends shallow-copying the viewConfig object in FullHeightController to prevent potential runtime errors when mutating frozen configuration objects.