SCAL-325130: Enable centralized Liveboard filter UX by default in embed - #644
SCAL-325130: Enable centralized Liveboard filter UX by default in embed#644ramjith-thoughtspot wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the default = false value for isCentralizedLiveboardFilterUXEnabled in both AppEmbed and LiveboardEmbed components, allowing it to remain undefined when not explicitly set. This aligns with the repository style guide to prefer undefined over false for boolean parameters to avoid bloating the URL. Corresponding unit tests have been added to verify that the parameter is omitted from the iframe URL when undefined. Additionally, the JSDoc documentation in src/types.ts has been updated to reflect that this feature is GA from SDK version 1.52.0 and ThoughtSpot version 26.6.0.cl, and its default value is documented as true. I have no feedback to provide as the changes are correct and follow the repository style guides.
commit: |
1 participant
No description provided.