SCAL-335430-POC Send embed config over postMessage instead of the iframe URL - #646
Open
shivam-kumar-ts wants to merge 6 commits into
Open
SCAL-335430-POC Send embed config over postMessage instead of the iframe URL#646shivam-kumar-ts wants to merge 6 commits into
shivam-kumar-ts wants to merge 6 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the full-height logic from AppEmbed and LiveboardEmbed into a new shared FullHeightController class, and introduces a sendConfigAsPostMessage option to transmit embed configurations via postMessage instead of URL query parameters. The review feedback highlights several style guide violations regarding American English spelling ('behavior' and 'honored') and JSDoc tag ordering. Additionally, it suggests incorporating defensive programming checks in the new controller to safely handle potentially null or undefined payload data and iframe references, preventing potential runtime crashes.
commit: |
shivam-kumar-ts
force-pushed
the
SCAL-335430-POC
branch
from
August 31, 2026 13:08
8bfcb63 to
5f7b601
Compare
shivam-kumar-ts
force-pushed
the
SCAL-335430-POC
branch
from
August 31, 2026 14:27
5f7b601 to
efe910d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.