Skip to content

Fix H.264 video snapshot showing dormant MJPEG frame rate - #6

Merged
scott-tp merged 1 commit into
masterfrom
feature/fix-video-snapshot-fields
Sep 18, 2026
Merged

scott-tp merged 1 commit into
masterfrom
feature/fix-video-snapshot-fields

Conversation

@scott-tp

@scott-tp scott-tp commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Show only mode-relevant video settings in the expanded device snapshot (same row layout as today).
  • H.264: bitrate and high-performance mode On/Off — do not show unused mjpegFrameRate.
  • MJPEG: frame rate and quality only.

Test plan

  • Hard-refresh dashboard against an H.264 device: Video section shows Streaming mode, Bitrate, High-performance mode — not “11 fps”
  • Switch a device to MJPEG in WebUI, refresh snapshot: Frame rate + Quality appear; no H.264 bitrate row
  • pytest passes
    Review on CodeApprove

Only show mode-relevant video knobs: MJPEG frame rate/quality, or
H.264 bitrate and high-performance mode — matching the device Web UI.
@scott-tp
scott-tp merged commit 539d9f6 into master Sep 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant