Skip to content

Address August sweep follow-ups - #874

Open
yzxcj797 wants to merge 1 commit into
tirth8205:mainfrom
yzxcj797:fix/866-august-sweep-followups
Open

Address August sweep follow-ups#874
yzxcj797 wants to merge 1 commit into
tirth8205:mainfrom
yzxcj797:fix/866-august-sweep-followups

Conversation

@yzxcj797

Copy link
Copy Markdown
Contributor

Summary

Addresses the small follow-ups collected in #866:

  • get_affected_flows now includes truncated: false on its no-changed-files early return.
  • JS/TS module suffix substitution now supports:
    • ./foo.jsfoo.jsx;
    • ./foo.mjsfoo.mts;
    • ./foo.cjsfoo.cts;
    • direct .mts / .cts source resolution.
  • dead-code and forget resolve their graph path in read-only mode so a missing graph no longer creates an empty .code-review-graph/ directory.
  • crg-daemon configures UTF-8 stdio like the main CLI.
  • Daemon forced-stop handles the Windows race where a vanished PID raises OSError/WinError 87.

Fixes #866.

Testing

  • Added focused regressions for each code-level follow-up.
  • Extended the missing-graph CLI test to assert that no data directory is materialized.
  • pytest tests/test_pr866_followups.py tests/test_cli_reconciliation.py::test_dead_code_missing_graph_exits_nonzero -q — 7 passed
  • ruff check on all changed files — passes
  • git diff --check — passes

@github-actions

Copy link
Copy Markdown

code-review-graph review

Overall risk: 0.65 (MEDIUM) — 16 changed function(s)/class(es), 0 affected flow(s), 4 test gap(s)

Risk-scored changes

Risk Level Symbol Location Tested
0.65 medium code_review_graph/daemon_cli.py::_configure_utf8_stdio code_review_graph/daemon_cli.py:26 yes
0.55 medium code_review_graph/daemon_cli.py::main code_review_graph/daemon_cli.py:258 no
0.40 medium code_review_graph/tools/review.py::get_affected_flows_func code_review_graph/tools/review.py:292 yes
0.35 low code_review_graph/cli.py::main code_review_graph/cli.py:624 no
0.35 low tests/test_pr866_followups.py::Stream tests/test_pr866_followups.py:78 yes
0.30 low code_review_graph/daemon_cli.py::_handle_stop code_review_graph/daemon_cli.py:73 yes
0.30 low code_review_graph/parser.py::CodeParser code_review_graph/parser.py:2405 yes
0.30 low tests/test_cli_reconciliation.py::test_dead_code_missing_graph_exits_nonzero tests/test_cli_reconciliation.py:482 (test)
0.30 low tests/test_pr866_followups.py::Stream.reconfigure tests/test_pr866_followups.py:81 no
0.25 low tests/test_pr866_followups.py::test_daemon_utf8_stdio_reconfigures_legacy_streams tests/test_pr866_followups.py:75 (test)

Test gaps

  • code_review_graph/cli.py::main (code_review_graph/cli.py:624)
  • code_review_graph/daemon_cli.py::main (code_review_graph/daemon_cli.py:258)
  • code_review_graph/parser.py::CodeParser._do_resolve_module (code_review_graph/parser.py:13596)
  • tests/test_pr866_followups.py::Stream.reconfigure (tests/test_pr866_followups.py:81)

Token savings: this graph-backed report used ~193,286 fewer tokens (~99%) than reading every changed file in full (estimated, chars/4 approximation).


Powered by code-review-graph — local-first analysis; no code leaves the CI runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small follow-ups from the August PR sweep

1 participant