Repository navigation
Fix installer trust boundaries and security audit findings - #1
Merged
Merged
Conversation
tneemo
force-pushed
the
codex/security-quality-audit-fixes
branch
from
October 19, 2026 16:54
3894579 to
ee6e933
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the 19 October security/quality audit (F01–F14), with per-finding changes, evidence and rollout notes in docs/security-audit-remediation.md.
Installation now stages and validates changes before writes, rejects Windows aliases and linked paths, decodes configuration before scanning, and requires explicit dependency-install opt-in. npm lifecycle scripts are disabled and pip accepts wheels only. Resolution includes unchanged installed consumers and discards rejected versions' dependency edges. Failed dependency commands return errors and can be retried without changing build versions.
Publishing verifies effective dependency sources and matching releases, fails closed on verification failures, and commits content-addressed bundle pointers. Readers verify integrity and yanking. Replayed downloads no longer influence counts or ranking. The Hono limiter uses socket peers and bounds key cardinality; mobile commands/tabs fit narrow viewports and support keyboard navigation.
Validation: 22 repository tests pass with no skips against a seeded local Worker; typecheck/build pass; assembled Node examples pass 11 tests plus typecheck; assembled Python examples pass 5 tests (one upstream deprecation warning); npm audit reports 0 advisories; isolated tarball checks cover both bins, setup and MCP; Chromium checks pass at 320/390/430px with normal/200% text. CI adds Windows security, assembled application and release smoke coverage.
Rollout: apply migration 0002 before deploying the Worker, then explicitly approve/release CLI 0.2.0 and publish hono-rate-limit 1.0.1. Existing npm/MCP publication guards remain intact. The original public-package 404 no longer reproduces (0.1.0 is available), but 0.2.0 is not published by this PR. Node >=24.10 is now required; dependency installation is opt-in and automatic Node installs support npm only. Unsupported dependency source formats require manual review. Filesystem checks assume no hostile concurrent path replacement; rollback does not cover abrupt process termination.