Skip to content

server.http2 and store.gcs.direct_connectivity are unused configuration #83

Description

@behinddwalls

Summary

server.http2 and store.gcs.direct_connectivity are exposed configuration fields but have no runtime consumers.

Current behavior

Changing either value has no effect. This makes the configuration misleading: operators can believe they have disabled HTTP/2 or changed GCS connectivity behavior when the server and store are unchanged.

Expected behavior

Each supported configuration option should control the documented runtime behavior. Unsupported options should not be accepted.

Suggested implementation

Either wire server.http2 into listener/protocol setup and store.gcs.direct_connectivity into GCS transport construction, or remove both fields and their documentation. Add configuration-level behavior tests for any retained options.

Relevant code

  • crates/walgit-config/src/lib.rs:43
  • crates/walgit-config/src/lib.rs:259

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions