feat(enclosure): LED pill above every pedal + CLEAR/BANK label-top alignment - #368
Open
tomassasovsky wants to merge 1 commit into
Open
feat(enclosure): LED pill above every pedal + CLEAR/BANK label-top alignment#368tomassasovsky wants to merge 1 commit into
tomassasovsky wants to merge 1 commit into
Conversation
…ignment Issue #366, user-approved LED trial made real: - _has_led() -> all 10 pedals: 4 new pill slots over REC/PLAY, STOP, UNDO, MODE (labels shift rearward with the pill, same family as the tracks) - PEDAL_ROW2_V now derived from label-top alignment with SCREEN_TOP_V via SILK_CAP (cap/em ratio measured in the populated Fusion doc); CLEAR/BANK move +35.47 on-slope so their label tops sit on the screens' top line - encoder ring decoupled to ENC_V (stays on the old row-2 line -- it would hit the 7" screen if it followed) - REC/PLAY 2-line stack tightened (line pitch 1.15 -> 0.95 cap heights) - mid pedestals regenerate taller (platform H 48.2 -> 56.0); bottom vent field re-centres between the rows automatically - BOM/docs: 10x LED puck + 10x pill diffuser; indicatorLeds[7] -> [10] flagged as an open firmware/board follow-up (V1 board contract unchanged) Both Fusion docs (VAMP console (populated) + VAMP sheet metal) synced and verified by containment probes: slots/pills/labels/pedestals/vents all match the generator within 0.2 mm. Geometry assertions ALL PASS.
tomassasovsky
added
stage:in-review
This was referenced Jul 29, 2026
Owner
Author
|
CI note: only GitGuardian runs while this PR targets the parent branch — the test/build workflows trigger on PRs into |
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #366
Stacked on #361 — do not merge before it lands (base is
feat/console-fit-cherub-wtb006; retarget tomasterafter #361 merges).User-approved LED trial (all-pedal indicators) made real across the generator, both Fusion docs and the hardware docs:
_has_led()→ all 10 pedals: 4 new 60×6 pill slots over REC/PLAY, STOP, UNDO, MODE; their labels shift rearward with the pill like the track pedalsPEDAL_ROW2_Vis now derived from label-top alignment withSCREEN_TOP_VviaSILK_CAP(glyph cap/em ratio measured in the populated doc). CLEAR/BANK move +35.47 mm on-slope so their label tops sit exactly on the screens' shared top lineENC_V(old row-2 line) — following the pedals would collide with the 7" screenindicatorLeds[7]→[10]is flagged as an open firmware/board follow-up (manufactured V1 board contract intentionally unchanged in docs)Verification: geometry assertion suite ALL PASS; both Fusion docs ("VAMP console (populated)" + "VAMP sheet metal") synced and probed by point-containment scans — slots, pills, labels, pedestals and vents match the generator within 0.2 mm.