Repository navigation
[Epic][Thermo-Nuclear Quality] Remediation of structural and code-quality findings from #636 audit #645
Description
Context & Objective
Following the completion and closeout of Program #636 (Cross-port delta), a comprehensive thermo-nuclear code quality review was conducted across the codebase and recent deliverables (329acf2..0517eb2).
The review identified 1 critical lifecycle bug, 1 latent false-pass driver risk, 1 process signaling safety hazard, and 4 major 1,000-line limit breaches. Full reports and worked decompositions are documented in docs/audit/thermo-nuclear-636/.
Child Issues & Execution Waves
- Wave 1 ([Thermo-Nuclear][Wave 1] Fix OpenSpec active change resolution when all changes are complete #646): Fix OpenSpec active change resolution when all changes are complete (
scripts/openspec_change.py). - Wave 2 ([Thermo-Nuclear][Wave 2] Comprehensive -uall untracked file hygiene across host drivers and scripts #647): Comprehensive
-ualluntracked file hygiene across host drivers and scripts (scripts/drivers/omp.py,sync-antigravity-plugin.py,tests/test_cross_port_contracts.py). - Wave 3 ([Thermo-Nuclear][Wave 3] Decompose skills/poteto-mode/scripts/orch/store.ts below 1,000 lines #648): Decompose
skills/poteto-mode/scripts/orch/store.ts(1,677 lines) into modular subcomponents below 1,000 lines (types.ts,lock.ts,frontier.ts,store.ts). - Wave 4 ([Thermo-Nuclear][Wave 4] Decompose oversized test suites (harness & evidence) below 1,000 lines #649): Decompose oversized test suites (
test_verify_harness.py,test_evidence_durability.py,test_evidence_settlement.py) below 1,000 lines.
Dependency Graph
flowchart TD
Epic["Program Epic #645: Thermo-Nuclear Quality Remediation (Post-#636 Audit)"]
W1["Wave 1 (#646): Fix OpenSpec Active Change Resolution for Completed Changes"]
W2["Wave 2 (#647): Comprehensive -uall Untracked File Hygiene Across Host Drivers"]
W3["Wave 3 (#648): Decompose skills/poteto-mode/scripts/orch/store.ts Below 1,000 Lines"]
W4["Wave 4 (#649): Decompose Oversized Test Suites Below 1,000 Lines"]
Epic --> W1
Epic --> W2
Epic --> W3
Epic --> W4
W1 --> W2
W2 --> W3
W3 --> W4
Acceptance Criteria
validate_openspec_change(None)cleanly resolves tostate="none"and exits 0 when all changes are complete._isolation_residueandsync-antigravity-plugin.pypass-uall, preventing false clean readings whenstatus.showUntrackedFiles = nois configured.- Safe process termination contract explicitly guards against
pid <= 1. skills/poteto-mode/scripts/orch/store.tsdecomposed intotypes.ts,lock.ts,frontier.ts, and corestore.ts, with all files strictly under 1,000 lines.- All test suites in
tests/decomposed strictly below 1,000 lines. - Full test matrix (
bun test, pytest,verify-portable.py doctor --host all) passes cleanly without regression.
Activity
tommy-ca commentedon Oct 20, 2026
Program Epic #645 Closeout: Thermo-Nuclear Quality Remediation Complete
All 4 waves have been completed, verified via independent
pro-tier verifier subagents, squashed and merged tomain, and their respective issues closed.Wave Execution Summary
a03ec55-ualluntracked file hygiene & PID boundary safetyd527042orch/store.ts(1,677 lines) into modular subcomponents (< 500 lines)38654ca92c1902Key Achievements
Bug Remediation:
scripts/openspec_change.pysovalidate_openspec_change(None)cleanly resolves tostate="none"and exits 0 when all changes are complete.-uallacrossscripts/drivers/omp.pyandscripts/sync-antigravity-plugin.pyto eliminate latent false-passes caused bystatus.showUntrackedFiles = no.tests/test_cross_port_contracts.pyprocess signaling with non-positive PID boundary safety (target_pid <= 1).Structural Decomposition & 1,000-Line Ceiling Enforced:
skills/poteto-mode/scripts/orch/store.ts(1,677 lines) decomposed into 6 cohesive submodules:types.ts(312),lock.ts(84),frontier.ts(299),report.ts(230),tables.ts(383), and orchestratorstore.ts(465), with 100% backwards-compatible re-exports and automated size invariant tests.tests/test_verify_harness.py(1,437 lines) decomposed intotest_verify_harness_archive.py(157),test_verify_harness_guides.py(311),test_verify_harness_playbooks.py(352), andtest_verify_harness.py(595).tests/evidence_test_helpers.py(362).tests/test_evidence_durability.py(1,016 lines) decomposed intotest_evidence_index_resilience.py(358) and coretest_evidence_durability.py(585).tests/test_evidence_settlement.py(1,003 lines) reduced to 762 lines.Matrix & Verification Health:
bun test: 102 passed, 0 failed.