ci(windows): add windows-process workflow for OpenProcess liveness verification (#1911 follow-up) - #1913
Merged
Merged
Conversation
…rification Follow-up to PR #1911 (fix(util): OpenProcess ERROR_INVALID_PARAMETER means dead, #1723 case 1). CI runs ubuntu-only, so the Windows branch of IsProcessAlive (OpenProcess + non-blocking WaitForSingleObject) never executes in CI; windows-proxy only covers the proxy stack. This workflow runs the IsProcessAlive tests on a real windows-latest kernel, where TestIsProcessAlive_NonExistent is the regression sentinel for the 87 verdict. Mirrors windows-proxy (#761) conventions; per the standing windows-real-machine policy. Co-Authored-By: ggcode <noreply@ggcode.dev>
topcheer
commented
Sep 9, 2026
topcheer
left a comment
topcheer
left a comment
Owner
Author
There was a problem hiding this comment.
Real-machine evidence (windows-latest runner, run 34332189217, head 56f67ab) — all 5 IsProcessAlive tests PASS on a real Windows kernel, including the #1911 regression sentinel:
--- PASS: TestIsProcessAlive_CurrentProcess (0.00s)
--- PASS: TestIsProcessAlive_NonExistent (0.00s) <- 87=dead verdict guard
--- PASS: TestIsProcessAlive_InvalidPID (0.00s)
--- PASS: TestIsProcessAliveProc_CurrentProcess (0.00s)
--- PASS: TestIsProcessAliveProc_Nil (0.00s)
PASS
This IS the post-#1911 windows-real-machine smoke per standing policy; the workflow makes it permanent (path-triggered on internal/util/process*.go). Static evidence: YAML OK, GOOS=windows go build ./internal/util/ exit 0. Will merge via admin exemption channel per the shared-credential rule.
topcheer
pushed a commit
that referenced
this pull request
Sep 11, 2026
Ships the code-review campaign since v1.3.236 (issue #1481-#1886, PR #1893-#2092), all verified via make verify-ci (9m03s, core checks passed) plus desktop-module build (blocker #2094 fixed pre-release): - agent: 20+ detector false-positive fixes (CJK/rune safety), guidance budget unification, claim-verify/verification-debt, secret redaction coverage, cache invalidation discipline - tui: configMutationMsg unification family (slack/wecom/dingtalk/twitch/ five panels), stdout O_NONBLOCK+Poll probe rewrite, tunnel replay + approval/ask_user id hardening (#1825 + follow-up ccff5cfa) - tool: git safety (dash-args, -- separators, sensitive scans), terminal adapters (iterm2/ghostty/warp), mobile pre-tap errors, rune-safe caps - mobile: QR scanner ownership, ohos degradation, relay replay cursor - desktop/webui/im/provider/plugin/swarm: leak guards, silent-error elimination, WS frame guarantees, MCP takeover race, DeleteTeam lock - release blockers fixed pre-tag: #2094 desktop compile (1d3da27), wailskit goroutine gate (e48fc4c) - feat: browser screenshot output_path (#1993); ci: windows-process workflow (#1913) Sweep clean: 4 version files only (1.3.237+2026091201). Co-Authored-By: ggcode <noreply@ggcode.dev> Co-Authored-By: ggcode <noreply@ggcode.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1911 per the standing windows-real-machine policy.
Why: CI is ubuntu-only; the Windows branch of
IsProcessAlive(OpenProcess + non-blockingWaitForSingleObject, incl. the new ERROR_INVALID_PARAMETER=dead verdict) never executes in CI.windows-proxycovers only the proxy stack.TestIsProcessAlive_NonExistentasserts false and turns red on a real Windows kernel exactly when the 87 branch regresses (stated in #1911).What: new
windows-processworkflow mirroringwindows-proxy(#761) conventions: windows-latest, path-triggered oninternal/util/process*.go+ the workflow file itself, plus workflow_dispatch. Test step:go test -tags goolm -count=1 -v -run "IsProcessAlive" ./internal/util/— filter covers all 5 tests (TestIsProcessAlive_CurrentProcess/NonExistent/InvalidPID,TestIsProcessAliveProc_CurrentProcess/Nil, name cross-checked per prior filter-miss lessons).Validation (isolated clone at f21ef8f):
GOOS=windows GOARCH=amd64 go build -tags goolm ./internal/util/exit 0🤖 Generated with ggcode