Conversation
kill(pid, 0) succeeds for a zombie (exited but unreaped), so IsProcessAlive reported dead instances as alive - crash-recovery anchors (run_journal) and IM instance detection kept stale state instead of cleaning it up. The issue rated this Low-Med: the error direction is fail-safe (residue over wrongful deletion) and needs a hung-parent window. On Linux, signal-0 success is now followed by a /proc/<pid>/stat state check: Z/X/x states are reported dead. Platforms without /proc (e.g. macOS) keep the signal-0-only verdict - documented, conservative. Parse uses the LAST ')' so comm fields containing spaces/parens stay safe. Windows is untouched (its helper already handles exit state). Pin: zombie-not-alive (real child + poll to Z state; skips on /proc-less hosts) + verdicts-unchanged for live/dead. util suite PASS (p=1); GOOS=windows build OK. Closes #1839 Co-Authored-By: ggcode <noreply@ggcode.dev>
topcheer
commented
Sep 9, 2026
topcheer
left a comment
Owner
Author
There was a problem hiding this comment.
验证证据(隔离 worktree):util 全套 PASS(-p=1)+GOOS=windows 交叉 OK。钉扎真实子进程轮询至 Z 态(macOS 无 /proc 按设计跳过——Linux CI 实跑)+live/dead 判定不变守卫。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1839 (case 1; the remaining findings were falsified/adjudicated in the issue).
Verification evidence (review)
Isolated worktree: util suite PASS (p=1) + GOOS=windows build OK. Pin: real-child zombie (polls to Z state; skips on /proc-less hosts — runs for real on Linux CI) + verdicts-unchanged for live/dead.
Closes #1839
Generated with ggcode