Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions docs/copilot-pr-reviews/pr-2187-copilot-suggestions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
---
semantic-links:
skill-links:
- process-copilot-suggestions
related-artifacts:
- .github/skills/dev/pr-reviews/process-copilot-suggestions/SKILL.md
---

<!-- cspell:disable -->

<!-- skill-link: process-copilot-suggestions -->

# PR #2187 Copilot Suggestions Tracking

Source: Copilot PR review threads for <https://github.com/torrust/torrust-tracker/pull/2187>

Status legend:

- `action`: code/docs change applied
- `no-action`: suggestion reviewed; no code change needed
- `resolved`: thread resolved in PR

## Processing Log

- 2026-09-09 14:35 UTC: Started processing suggestions (two unresolved threads, both on `docs/issues/open/2183-adopt-calendar-msrv-policy/ISSUE.md`).
- 2026-09-09 14:37 UTC: Declined thread 1 after confirming the file carries no doubled pipe and that GitHub's own renderer produces no leading blank column for either flagged table.
- 2026-09-09 14:39 UTC: Accepted thread 2 and moved the pin extraction command out of the implementation-plan table into a fenced block under Job shape, in commit `4d83ff44`.
- 2026-09-09 14:40 UTC: Gated the commit on the build server: `linter all` passes in 18.2 s, and the relocated command run verbatim against the branch's `Cargo.toml` prints the pin.
- 2026-09-09 14:46 UTC: Pushed commit `4d83ff44` to the pull request branch, a fast-forward from `96f06057`.
- 2026-09-09 14:46 UTC: Replied on thread 2 with the fix commit and its validation, and resolved it immediately after the reply.
- 2026-09-09 14:46 UTC: Replied on thread 1 with the evidence that the reported pattern is absent from the file, and resolved it immediately after the reply.
- 2026-09-09 14:47 UTC: Re-fetched the pull request's review threads and confirmed both are resolved and none remains open.

## Suggestions

| # | Thread ID | Path | URL | Suggestion Summary | Decision | Reply URL | Status | Thread State |
| --- | ----------------------- | ----------------------------------------------------------- | ----------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------ | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------- | ------ | ------------ |
| 1 | `PRRT_kwDOGp2yqc6gswm_` | `docs/issues/open/2183-adopt-calendar-msrv-policy/ISSUE.md` | <https://github.com/torrust/torrust-tracker/pull/2187#discussion_r3969598486> | The tables start every row with a doubled pipe, which GitHub-flavored Markdown renders as an unintended empty first column. | no-action — the premise does not hold for this file. A search for a doubled pipe over the whole document returns nothing, and each of the 44 table lines begins with a single pipe followed by a space. Rendering the flagged Computation table through GitHub's own Markdown endpoint returns three header cells, `Release`, `Published` and the dated question, with six body cells and a first column that reads `1.89.0` and `1.90.0`; the implementation-plan table renders four cells per row on the same evidence. There is no blank column to remove and nothing to change. | <https://github.com/torrust/torrust-tracker/pull/2187#discussion_r3969769302> | DONE | RESOLVED |
| 2 | `PRRT_kwDOGp2yqc6gswn_` | `docs/issues/open/2183-adopt-calendar-msrv-policy/ISSUE.md` | <https://github.com/torrust/torrust-tracker/pull/2187#discussion_r3969598582> | The T3 command example carries an escaped pipe, so copying it verbatim into a shell fails; use `&#124;` or move it to a fenced code block. | action — commit `4d83ff44`. The concern holds for the source rather than the rendered page: GitHub's renderer consumes the escape, so the pull request already displayed a working pipe, but the raw markdown carries the backslash, and these specifications are implemented from the file in the tree, so the source is the form that has to be copyable. The command moved into a fenced `bash` block under Job shape, where the pipe needs no escape, and the T3 row now points at it. The entity form was declined: inside a code span it is not decoded, so it would render literally and break both views. | <https://github.com/torrust/torrust-tracker/pull/2187#discussion_r3969767724> | DONE | RESOLVED |

## Notes

- Keep this file as an audit log of review handling for the PR.
- Reply on every PR suggestion thread before resolving it so the decision is visible to reviewers.
- Suggestion 1 evidence: a search for two consecutive pipe characters over `ISSUE.md` returns no match, and a dump of the first two characters of every line that opens a table row shows a pipe and a space in all 44 cases. Passing lines 97 to 100 to the repository host's Markdown rendering endpoint in GitHub-flavored mode yields one table with three `th` elements and six `td` elements, the first body row being `1.89.0`, `2025-08-07` and the dated answer. Passing the implementation-plan header, delimiter and T3 row yields four `td` elements. An unintended leading column would have shown as an extra empty cell in both counts, and does not.
- Suggestion 2 evidence: the same rendering endpoint, given the unmodified T3 row inside its own table, returns the code span `sed -n 's/^rust-version = "\(.*\)"/\1/p' Cargo.toml | head -1` with the backslash consumed, so the pull request page was already correct and only the source was not. Given a cell containing the entity form inside a code span, the endpoint returns the entity undecoded, which is why that alternative was rejected. The relocated command was run verbatim on the gate host against the branch's own `Cargo.toml`: it prints `1.88`, and without `head -1` it prints exactly one line, the property manual scenario M4 already asserts, because the anchored pattern cannot match the members' `rust-version.workspace = true` declarations.
- Validation: `linter all` passes on the build server at commit `4d83ff44` in 18.2 s, with markdown, link, YAML, TOML, spelling, clippy, formatting and shell checks all green.
Loading