Skip to content

docs(links): record hosted exclusion verification - #2200

Merged
josecelano merged 1 commit into
torrust:developfrom
josecelano:2185-record-c1-c9-hosted-verification
Sep 11, 2026
Merged

docs(links): record hosted exclusion verification#2200
josecelano merged 1 commit into
torrust:developfrom
josecelano:2185-record-c1-c9-hosted-verification

Conversation

@josecelano

Copy link
Copy Markdown
Member

Summary

  • records merged-upstream hosted verification for the C1/C9 dynamic review-comment-anchor exclusion
  • confirms no matching #discussion_r URLs remained, while unrelated external-link failures and the failure report remained visible
  • records the cancelled initial dispatch accurately and preserves the independent review result

Validation

  • linter markdown
  • linter cspell
  • linter lychee
  • ./contrib/dev-tools/git/hooks/pre-commit.sh
  • ./contrib/dev-tools/git/hooks/pre-push.sh

Related to #2185
Related to #2003

Copilot AI lite review requested due to automatic review settings September 11, 2026 09:02
@josecelano josecelano self-assigned this Sep 11, 2026
@josecelano

Copy link
Copy Markdown
Member Author

ACK 51e2e5c

@josecelano
josecelano merged commit 6831132 into torrust:develop Sep 11, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Documents hosted verification that the C1/C9 Lychee exclusion for GitHub PR review-comment anchors works as intended, while preserving visible unrelated failures and correcting the record for a cancelled run.

Changes:

  • Added “Hosted Verification” evidence (run link, revision, counts, and observed residual failures) to the external-link baseline.
  • Added a new independent reviewer report log (agent-review-reports.md) and linked it from the issue spec.
  • Updated issue status/acceptance criteria/metrics to reflect verified T3/T4 completion and corrected cancelled-run wording.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/issues/open/2185-2003-triage-advisory-external-link-check-findings/external-link-baseline.md Adds hosted-run verification narrative and result counts for the exclusion boundary.
docs/issues/open/2185-2003-triage-advisory-external-link-check-findings/agent-review-reports.md Introduces an append-only log of independent review reports tied to the issue’s evidence set.
docs/issues/open/2185-2003-triage-advisory-external-link-check-findings/ISSUE.md Updates progress tracking and links to include hosted verification and the reviewer report entry.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +142 to +146
[External Link Check run 34578523069](https://github.com/torrust/torrust-tracker/actions/runs/34578523069) ran the merged configuration on revision `427b0c93b01f1264f7ef824097ac5669d899486c`. The `Check External Links` step failed visibly and `Upload Lychee Report` succeeded; the retained `lychee-external-link-report` artifact is 1,743 bytes and expires on 2026-09-25.

The report recorded 1,816 total checks, 1,288 successful checks, 26 redirects, 476 excluded links, 52 errors, and no timeouts. No URL matching the exact `https://github.com/torrust/torrust-tracker/pull/<number>#discussion_r<id>` pattern remained in the report. The excluded count is greater than the 424 baseline occurrences because the merged `develop` revision contained additional matching review-comment links.

The report still contained visible `404`, `403`, local loopback, GitHub issue-comment and pull-request-review fragments, third-party missing-fragment, and rate-limited diagnostics. This proves the C1/C9 rule suppresses the intended dynamic review-comment-anchor pattern without hiding unrelated categories. The remaining 52 errors are the next triage input; their exact count is not directly comparable to the 461-error baseline because the checked document set changed between revisions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants