Repository navigation
chore(ci): parallelize checks and cache CDK Docker images - #30
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests now validate every configured AWS environment in separate cloud assembly directories outside the checkout while pytest runs alongside them. CDK validation performs synthesis, so tests overlap synthesis without adding a redundant synthesis job. A wait barrier requires every check to succeed before saving Docker images.
AWS authentication starts in the background while frozen dependency installation and CDK CLI setup run, with an explicit wait before deployment validation. Existing dev/test push triggers and the manual production trigger remain unchanged.
Docker bundling images use a weekly, platform-specific cache with the full checked-out Git tree as the source key and same-week fallback. Tracked Dockerfiles and build-context inputs anywhere in the repository affect the key. Any tracked file change creates a new entry; same-week fallback still restores existing images. CDK's content fingerprint decides whether to reuse an image. Apps without Docker images skip archive creation and upload. The cache covers bundling images created during synthesis/tests, not image assets published by deployment.
The generated workflows use named
backgroundsteps and explicitwaitbarriers, as verified on GitHub in aws-cdk-ttc PR #25. A temporary path-scoped actionlint exception suppresses only unsupported background/wait diagnostics while native lint support is pending. Ordinary script and action validation remains enabled.Validation on macOS ARM64 with Python 3.13 and CDK CLI 2.1139.0:
agent-validate check --prpassed the workflow checks.uv run ty checkand all 4 pytest tests passed. Changed Python files pass Ruff lint and formatting.Repository-wide Ruff checks report existing import/formatting issues in unchanged application/helper files and documentation examples. The changed files are clean. The current starter app has no Docker bundling assets, so cache speed gains are unmeasured. Local scripts/logs are in the chat scratchpad; Local validation passed on
3409801, including 4 tests. GitHub validation passed for3409801, including all 4 tests and both concurrent environment validations. Codex review completed without findings on that commit. No AWS deployment was run locally.