#22 Load only required fabric API modules - #183
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR narrows the project’s Fabric API dependency surface area by switching from the full fabric-api bundle to only the Fabric API lifecycle events module that the mod actually imports, reducing build/runtime dependency footprint without changing gameplay behavior.
Changes:
- Replaced the Gradle dependency on
net.fabricmc.fabric-api:fabric-apiwithfabric-lifecycle-events-v1via Loom’sfabricApi.module(...)helper. - Updated
fabric.mod.jsonto depend onfabric-lifecycle-events-v1instead offabric-api. - Bumped
mod_versionto26.2-0.18.0.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/main/resources/fabric.mod.json |
Updates runtime mod dependency to the specific Fabric API module used (fabric-lifecycle-events-v1). |
plans/fabric-api-module-split-plan.md |
Adds a design/verification plan documenting the rationale, approach, and validation steps. |
gradle.properties |
Bumps the mod version for the release containing the dependency change. |
build.gradle |
Switches build-time dependency from full Fabric API to the lifecycle-events module only. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.