Skip to content

feat(api): accept extended=rating on social activity - #1045

Merged
StefanFriptu merged 1 commit into
masterfrom
feat/social-activity-rating
Oct 28, 2026
Merged

StefanFriptu merged 1 commit into
masterfrom
feat/social-activity-rating

Conversation

@StefanFriptu

@StefanFriptu StefanFriptu commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

What

GET /users/:id/:type/activities already returns user_rating, but its extended type did not list rating, so typed SDK callers could not ask for it. Official apps already send extended=...,rating,... on almost every call.

  • extended for this route is now full | images | colors | streaming_ids | rating. rating goes last so an existing value with ,rating appended still type-checks.
  • The description now carries the 🫣 Limited Access badge: only first-party Trakt applications can call this route, and third-party applications receive a 403.
  • It also states the 7-day window, that a private user's activity only shows to people who follow them, and what extended=rating adds.

No response schema change: user_rating is already int | null.

Release

Additive, type-only. Hold the publish until the server serves this route with the stated behaviour; merging alone does not publish.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T13:40:56.663611Z 85eed2f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@StefanFriptu

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85eed2f1f3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread projects/api/src/contracts/users/index.ts Outdated
@StefanFriptu
StefanFriptu force-pushed the feat/social-activity-rating branch 2 times, most recently from e742efc to dc4b1bb Compare October 28, 2026 13:59
Social activity returns each person's user_rating when the request asks for extended=rating.

The description now states the 7-day window and that a private user's activity only shows to people who follow them.

It also marks the route as limited to first-party Trakt applications.
@StefanFriptu
StefanFriptu force-pushed the feat/social-activity-rating branch from dc4b1bb to e281ace Compare October 28, 2026 14:00
@StefanFriptu
StefanFriptu merged commit 105e41f into master Oct 28, 2026
6 checks passed
@StefanFriptu
StefanFriptu deleted the feat/social-activity-rating branch October 28, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant