Repository navigation
fix(api): describe younify refresh as the apps call it - #1050
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c72e7ca9f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Adds POST /younify/users/refresh with a required service_id in the body, an optional skip_sync body on every refresh route, and a 201 response, which is what the endpoint answers. all_data is documented as true/false.
StefanFriptu
force-pushed
the
fix/younify-refresh-contract
branch
from
October 29, 2026 11:55
1c72e7c to
fca998d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The younify refresh contract now describes the endpoint the way clients call it and the way it answers.
refreshServiceroute:POST /younify/users/refreshwith the service in the body,{ service_id, skip_sync? }.service_idis required.{ skip_sync? }body onrefreshandrefreshAll.skip_sync: truemarks the service as synced now, so older history is ignored.201. A client checkingstatus === 204treats every successful refresh as a failure, and will now get a type error pointing at that check.all_datadocs: a full re-sync needs the segment to betrue. Any other value is an incremental re-sync.Breaking for typed clients only through the status change, which corrects the contract to what the server already returns.
Checked with
publish:checkandopenapi:validate.