chore: adopt coding standards and agent skills, drop Median - #201
Open
github-actions[bot] wants to merge 4 commits into
Open
chore: adopt coding standards and agent skills, drop Median#201github-actions[bot] wants to merge 4 commits into
github-actions[bot] wants to merge 4 commits into
Conversation
CODING_STANDARDS.md becomes the first row of the AGENTS.md table, so it is read before any code is written. Fifteen mattpocock skills join the fourteen already tracked under .agents/skills, and docs/agents/ records the per-repo configuration they expect: issues live in Linear team CRM, the five canonical triage labels, and a single-context domain model. Median is gone. Issues are tracked in Linear, and the commit and pull request conventions it documented were wrong for this repo anyway: pr-title.sh writes PR titles from the diff and rejects a subject that does not start with a conventional-commit type, so an issue id in the subject stops the automation.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 57 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
docs/agents/domain.md named docs/adr/, which does not exist. The ADRs are in adrs/ at the root, one file per topic and unnumbered, and an agent following the old path missed every decision it was told not to relitigate. The doc now names adrs/, says a skill naming docs/adr/ means adrs/, marks CONTEXT.md as not written yet, cites adrs/i18n.md instead of an invented ADR-0007, and lists typescript-config in the packages line. AGENTS.md's Domain docs entry follows. pr-title.yml retitles a bad pull request title rather than stopping, so "stops the automation" was wrong in both docs/agents/issue-tracker.md and AGENTS.md. Both now say the check fails, the workflow writes a replacement from the diff, and the id is thrown away. The rule is unchanged: no issue id in a subject. CODING_STANDARDS.md section 5 permitted a comment that explains why, which contradicts AGENTS.md's absolute "never add code comments". AGENTS.md wins and the two bullets collapse into one. hitl-loop.template.sh was committed with CRLF, so its shebang read "#!/usr/bin/env bash\r" and the template could not run on Linux or macOS. It is LF now. handoff and implement are two of the skills ask-matt routes to.
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 10 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
The example named scope-groups.tsx with a caption prop and a SCOPE_CAPTION constant. None of those exist: the component is apps/app/.../slack/slack-scope-groups.tsx, its props are title, groups and withheld, and scope-groups.tsx only exists on feat/hubspot-connection. An agent reading AGENTS.md went looking for a file that is not on main. packages/email is not a package either. The directory holds a stale .turbo and node_modules, no source and no package.json, and git tracks nothing in it. The packages line drops it.
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
SlackScopeGroups hardcodes two strings, and one of them names Slack: "Broad means the whole workspace, not one channel" and "Slack held this one back, so it is off." The paragraph now says what is true instead — the component imports @crm/ui and icons only, and the page owns the grouping and the withheld set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened automatically when
chore/agent-conventionswas pushed.The title is written from the diff and rewritten as you push, because this is squashed onto
mainand the title becomes the commit subject and the changelog line. Retitle it yourself and it is yours — the automation stops touching it.Summary by cubic
Adds repo-wide coding standards and 15 pinned Matt Pocock skills, and replaces Median-based agent tracking with Linear team CRM. This updates agent guidance and configuration only; product runtime behavior is unchanged.
CODING_STANDARDS.mdthe first read-first rule inAGENTS.md.adrs/layout, and five Linear triage labels.pr-title.ymlrewrites invalid titles from the diff and drops issue IDs.handoffandimplementskills to theask-mattroutes.AGENTS.mdSlack example, package list, and scope component description.Written for commit eb5a0f1. Summary will update on new commits.