Repository navigation
Reject malformed benchmark posts instead of crashing the review - #62
Closed
kbatchelli wants to merge 1 commit into
Closed
kbatchelli wants to merge 1 commit into
kbatchelli wants to merge 1 commit into
Conversation
Several fields in a post could raise TypeError, ValueError, OverflowError or AttributeError instead of Rejected: timestamps without a time zone or that don't parse, integers too large for a float, a list as the model id or workload, and the optional load_seconds, peak_memory_bytes, settings and check fields that build_dataset uses. Because parsed() runs over every post in the category, one such post broke every later review and the leaderboard build.
Collaborator
|
Thanks! Great Work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to the fix: 6 of the test cases were crashing and 3 were being incorrectly accepted
After: all tests in Scripts/test_benchmark_discussions.py pass
Other checks: no checks on the Swift side since it was only the python side