Repository navigation
Conversation
expandConfig normalized the option with `concurrency || 20`, which turns the documented "0 disables concurrency limits" into the default of 20. Use `??` so only a missing value falls back to the default. The sqlite3 client sizes its connection pool from the same config value; map a preserved 0 to an unbounded pool there too, matching the http and ws clients where promise-limit treats a falsy limit as pass-through. Fixes #351
Author
|
Closing this one so it does not sit in the queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
concurrency: 0is documented inapi.tsas disabling the limit, butexpandConfigturns it into20, so the one value that is supposed to mean "no limit" is the one that silently gets the default.
The cause is
concurrency || 20inpackages/libsql-core/src/config.ts:0is falsy, so it takesthe same branch as
undefined. Changed to??, which distinguishes "not supplied" from "supplied aszero". The surrounding
Math.max(0, ...)is unchanged, so a negative value still clamps.Tests cover the default, an explicit limit, and zero.
Fixes #351