Resolve Nds4j from Maven Central instead of building it in CI - #9
Merged
Merged
Conversation
Nds4j 1.0.0 is published to Central and this module pins that exact version, so the three steps that resolved a branch, cloned Nds4j and installed it from source no longer affect what the build resolves. Since Nds4j's main branch moved to 1.1.0-SNAPSHOT they are worse than redundant: each run cloned a repository and ran a full build to install a coordinate nothing here asks for, and the resulting jar was ignored. Removing them also means CI now tests against the same artifact anyone depending on this library downloads, rather than a locally built one that could quietly differ from the published 1.0.0. The branch matching those steps performed is genuinely lost: a change spanning this repository and Nds4j can no longer be exercised together in CI. That trade is deliberate. Picking up new Nds4j behaviour now means bumping the version pin here, which is a reviewable line in a diff rather than an implicit consequence of a branch name. Verified by building with -Dmaven.repo.local pointed at an empty directory: Nds4j 1.0.0 was downloaded from Central (confirmed by the central marker in _remote.repositories) and the suite passed, 42 tests with 11 skipped for want of a ROM. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RqYGZhtVb8KrPA9ftp5bob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nds4j 1.0.0 is on Maven Central and this module pins that exact version, so the three CI steps that resolved a branch name, cloned Nds4j and installed it from source no longer affect what the build resolves.
Since Nds4j's
mainmoved on, those steps are worse than redundant: each run cloned a repository and ran a full build to install a coordinate nothing here asks for, and the resulting jar was then ignored. Removing them also means CI tests against the same artifact anyone depending on this library downloads, rather than a locally built one that could quietly differ from the published 1.0.0.What is lost
The branch matching those steps performed is genuinely gone: a change spanning this repository and Nds4j can no longer be exercised together in CI. That trade is deliberate. Picking up new Nds4j behaviour now means bumping the version pin here, which is a reviewable line in a diff rather than an implicit consequence of a branch name — and full-stack testing is better served by a local checkout of all four repositories, where a sibling snapshot can be
mvn installed and the exact combination about to ship gets exercised.Verification
Built with
-Dmaven.repo.localpointed at an empty directory, so nothing could resolve from a previously installed jar:Nds4j-1.0.0.jarwas downloaded, and_remote.repositoriesrecordsNds4j-1.0.0.jar>central=— it came from Central, not from a local install.Generated by Claude Code