Repository navigation
test: add test to reproduce single page queue full - #141
Merged
Merged
Conversation
lulf
force-pushed
the
single-page-queue-issue
branch
from
October 1, 2026 08:33
e37bf1a to
b6c5df7
Compare
Member
|
Cool! Implemented the fix. Didn't like the AI suggestion. Instead I factored out the part of the function we actually want to call instead of providing a false state |
Member
|
Released as 8.0.2 |
Contributor
Author
|
Great, thanks @diondokter ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feel free to close this if it's the expected behavior. But we ran into this issue where if you use a single page for a queue, where you push and pop with overwrite = false, you will eventually get stuck in StorageFull.
Disclosure: I used AI to reproduce this issue, but simplified the test case to the one in this PR.
Also, AI proposed a fix, which involes changing this piece of code to pass PageState::Closed instead of next_page_state if it's a single page.