Repository navigation
Gate the _check-cache verification with #[cfg] instead of cfg!() - #144
Merged
Merged
Conversation
The cfg!() check is a runtime-false condition, so the await inside it still adds a suspend state to get_page_state_cached's state machine, which the optimizer cannot remove. The verification code was compiled into every build. Measured -272 bytes of .text on a thumbv7em firmware.
diondokter
approved these changes
Oct 10, 2026
Member
|
Interesting! Makes sense |
Member
|
Seems like CI thinks it saves 60 bytes. So that's an easy win. If you see anything else, you're welcome to create more PRs 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cfg!() check is a runtime-false condition, so the await inside it still adds a suspend state to get_page_state_cached's state machine, which the optimizer cannot remove. I use a very memory constrained device where optimizations like this matter.