Skip to content

fix(crawler): align publication validator forbidden-name filter #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twoimo merged 2 commits into from
Aug 16, 2026
Merged

fix(crawler): align publication validator forbidden-name filter #2559

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6cc67f
fix(crawler): update forbidden-name regex in publication validator
Aug 16, 2026
e16e0cf
Merge pull request #2558 from twoimo/develop
twoimo Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions backend/bin/validate_daily_publication_bundle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@
ALLOWED_MODES = {"0600", "0640", "0644", "0660", "0664"}
FORBIDDEN_COMPONENTS = {"frames", "video_cache", "temp_video", "thumbnails", "log", "logs"}
FORBIDDEN_NAME_PARTS = ("credential", "cookie", "secret", "token", "password", "log")
FORBIDDEN_NAME_RE = re.compile(
r"(?:^|[_\-.])(?:" + "|".join(re.escape(p) for p in FORBIDDEN_NAME_PARTS) + r")s?(?:[_\-.]|$)",
re.IGNORECASE,
)
SHA256_RE = re.compile(r"^[0-9a-f]{64}$")
SHA1_RE = re.compile(r"^[0-9a-f]{40}$")
ARTIFACT_DIGEST_RE = re.compile(r"^sha256:[0-9a-f]{64}$")
Expand Down Expand Up @@ -90,13 +94,13 @@ def _portable_path(value: object) -> str:

def _is_allowed_data_path(path: str) -> bool:
components = path.split("/")
name = Path(path).name.lower()
stem = Path(path).stem
return (
path.startswith(ALLOWED_ROOTS)
and path.endswith(ALLOWED_SUFFIXES)
and Path(path).name not in EXCLUDED_BASENAMES
and not any(component.lower() in FORBIDDEN_COMPONENTS for component in components)
and not any(part in name for part in FORBIDDEN_NAME_PARTS)
and not bool(FORBIDDEN_NAME_RE.search(stem))
)


Expand Down