Conversation
Client dashboard imported SHA-256 from node:crypto via the shared preview-hash helper. Hash with a browser-safe digest so webpack does not pull Node crypto into the admin bundle. Co-authored-by: twoimo <twoimo@example.com>
Operator Grafana stays loopback-only and out of the admin dashboard. Anonymous login and embedding are off; CSP is on; the admin password must come from GRAFANA_ADMIN_PASSWORD instead of a compose default. Co-authored-by: twoimo <twoimo@example.com>
Persist-on mutate writes pipeline_control jobs+locks+audit in one local transaction. GET stays FileStore and non-mutating. Default persist remains off. Co-authored-by: twoimo <twoimo@example.com>
Probe pipeline-api GET /v1/targets for job_api, else current-summary.json. If neither is available, source is none instead of a fake job_api flag. Co-authored-by: twoimo <twoimo@example.com>
* feat(pipeline): freeze Slice 3 metric names without OTel SDK Pin the control-plane counters in metrics.v1.json. record() stays noop, Kafka lag / ES rows/sec stay deferred, and the image stays copy-only. * feat(pipeline): wire noop Slice 3 metric record call sites MemoryStore enqueue/claim/Succeeded/Failed invoke record() as noop. Idempotency replay and Cancelled/Paused finish_dry_run do not. No OTel SDK, no export, no TZUDONG_PIPELINE_METRICS in overlay or GHA. --------- Co-authored-by: twoimo <twoimo@example.com>
…m FileStore (#2652) Persist-on dual-write still leaves GET on FileStore. After jobs+locks write, read those rows back and compare them to the FileStore RunRecord; mismatch rolls back and raises persist_divergence. Co-authored-by: twoimo <twoimo@example.com>
Replace the copy-only image freeze with pinned OpenTelemetry SDK + OTLP HTTP exporter so overlay record() can push the four frozen run counters to the existing collector scrape path. Default export stays off; GHA export attempts fail closed before the SDK import. Co-authored-by: twoimo <twoimo@example.com>
Return the same allowlisted live jobs and capped failures as the operator snapshot without targets. GET stays FileStore-backed and non-mutating. Co-authored-by: twoimo <twoimo@example.com>
Promote pipeline-control follow-ons to data
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
Closing as superseded by the recovery and control-plane remediation series based on current origin/develop. The current promotion is diverged from main and includes unresolved control-plane correctness and security findings. No branch or data is deleted; the exact head remains recorded in PR #2656 and will be replaced through reviewed develop -> data -> main promotions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote merged
data(#2655) ontomain.Includes:
#2654GET/v1/runsFileStore collection#2653OTel SDK OTLP frozen counters#2652persist divergence fail-close#2651Slice 3 metric-name freeze#2650dual-read system-status#2647dual-write local jobs/locks/audit#2648Grafana CSP/auth gate#2649pipeline preview hashes offnode:cryptoTest plan
#2653/#2654and prior develop PRs.#2655CI: 24/24 pass.Do not delete
dataon merge.