fix: 스켈레톤 해제와 배너 실패 코드 - #3036
Conversation
접힌 패널이 지도를 가리지 않게 하고, 서비스 롤 설정 실패도 banner_read_failed로 막는다. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0dd54267d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| useEffect(() => { | ||
| document.documentElement.dataset.homeChromeReady = "true"; | ||
| return () => { | ||
| delete document.documentElement.dataset.homeChromeReady; |
There was a problem hiding this comment.
On mobile/tablet, entering map fullscreen makes the conditional in home-client.tsx unmount HomeControlPanel, so this cleanup deletes the readiness attribute even though HomeStaticSkeleton remains mounted by MobileHomeLayout. The CSS selector stops matching and the top and bottom skeleton bars reappear over the fullscreen map; the one-way loading-complete state should not be cleared during this transient unmount.
Useful? React with 👍 / 👎.
| selectedAnnouncement = null, | ||
| }: HomeControlPanelProps) { | ||
| useEffect(() => { | ||
| document.documentElement.dataset.homeChromeReady = "true"; |
There was a problem hiding this comment.
On a fresh or throttled load, this effect runs when the outer HomeControlPanel chunk mounts, but the mobile and desktop controls are subsequently loaded through useDeferredComponent, and this component returns null until that second chunk resolves. The new selector therefore removes the only loading UI while no control chrome is rendered, producing a blank gap; mark readiness only after the selected deferred component is available or has mounted.
Useful? React with 👍 / 👎.
1 participant
Summary
banner_read_failed로 반환합니다.Test plan
Made with Cursor