Skip to content

Test case for issue #8325 - #8326

Merged
mernst merged 1 commit into
typetools:masterfrom
mernst:issue8325
Oct 8, 2026
Merged

mernst merged 1 commit into
typetools:masterfrom
mernst:issue8325

Conversation

@mernst

@mernst mernst commented Oct 7, 2026

Copy link
Copy Markdown
Member

Fixes #8325.

Adds a test case for BitSet.clear(). The fix is in the annotated JDK; merge it first: typetools/jdk#302

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: typetools/checker-framework/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2e93f1b7-3e2d-446a-bba3-74787ce8f79f
📥 Commits

Reviewing files that changed from the base of the PR and between 0091b16 and b259ca3.

📒 Files selected for processing (1)
  • checker/tests/nullness/jdkannotations/Issue8325.java

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Adds a nullness test fixture that calls the no-argument, single-index, and range overloads of BitSet.clear. The fixture also calls field.toString() inside a field != null branch after clearing the bit set.

Priority: ⬇️ Low

Change: Other · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to b259c

This change adds regression test coverage only and does not affect runtime behavior. The fix itself lives in the annotated JDK change that the author says should be merged first. Merge readiness risk is minimal.

🚥 Pre-merge checks | ✅ 1 | ❌ 1 | ❓ 1

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check ❓ Inconclusive The added Issue8325 fixture directly tests BitSet.clear() with zero, one, and two arguments. It also checks that a non-null refinement remains valid after clear(). The linked issue requires `@Si… Provide reviewable evidence that the annotated-JDK change is present at the reviewed head, or include the required annotation fix in the reviewed implementation.
✅ Passed checks (1 passed)
Check name Status Explanation
Out of Scope Changes check ✅ Passed The pull request adds only checker/tests/nullness/jdkannotations/Issue8325.java. The fixture directly supports issue #8325 by covering all three BitSet.clear() overloads and the relevant nullness …
Full details: Linked Issues check

Explanation

The added Issue8325 fixture directly tests BitSet.clear() with zero, one, and two arguments. It also checks that a non-null refinement remains valid after clear(). The linked issue requires @SideEffectsOnly("this") on all three overloads. The pull request diff does not include that annotation change. The referenced annotated-JDK pull request does not establish that the fix is present at this reviewed head.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mernst
mernst merged commit cd777e5 into typetools:master Oct 8, 2026
37 of 38 checks passed
@mernst
mernst deleted the issue8325 branch October 8, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4.3.0: BitSet.clear() fails with flowexpr.parse.index.too.big — @SideEffectsOnly("#1") on a no-arg method

1 participant