feat(stovepipe): add Ingest RPC to gateway for trunk commit verification#262
Merged
Merged
Conversation
This was referenced Jun 17, 2026
behinddwalls
added a commit
that referenced
this pull request
Jun 17, 2026
…#258) ## Summary Stacked on top of `refactor` (#257). Moves all proto wire contracts into a single top-level `api/` tree organized by `domain/service`, and lays the groundwork for upcoming messagequeue payload contracts. - Relocate each service's `proto/` and `protopb/` dirs to `api/{domain}/{service}/` (history-preserving renames). New importpath: `github.com/uber/submitqueue/api/{domain}/{service}/protopb`. - Update `go_package`, all Bazel importpaths, root `gazelle:resolve` hints, consumer `deps`, and all Go imports. - Generalize the `tool/proto` codegen rule (`srcs` list) and the `make proto` copy loop to support **multiple `.proto` files per service package**, so messagequeue contracts can later live alongside each service's RPC contract under the same `api/{domain}/{service}/proto/` dir. - Update docs (`CLAUDE.md` project layout / import paths / proto-gen workflow, `example/README.md`). The proto `package` declarations are intentionally left unchanged (only `go_package` moved) to avoid churning wire-level type names. ## Test plan - [x] `make build` - [x] `make test` (54/54 pass) - [x] `make check-gazelle` - [x] `make lint` - [x] `make check-tidy` - [x] `make proto` produces zero drift vs committed stubs Made with [Cursor](https://cursor.com) ## Stack 1. @ #258 1. #261 1. #262 Co-authored-by: Cursor <cursoragent@cursor.com>
behinddwalls
force-pushed
the
preetam/api-base-proto
branch
from
edf2fe0 to
cc1c653
Compare
behinddwalls
force-pushed
the
preetam/stovepipe-gw-ingest-proto
branch
from
32c7e57 to
40602a0
Compare
gsturges
reviewed
Jun 17, 2026
| // IngestResponse defines the response to an ingest request. | ||
| message IngestResponse { | ||
| // Globally unique identifier for the ingested commit's verification request (the "stovepipe id", spid). Used to track the request lifecycle. | ||
| string spid = 1; |
Contributor
There was a problem hiding this comment.
Can you give more clarification on what this ID is? Is it for identifying each request? If so should we store each request? Or is the id of the change(s) ingested into the queue. If so, shouldn't we give the id of each uri ingested into the queue?
Collaborator
Author
There was a problem hiding this comment.
yes, so this should be generated by gateway against a queue and the counter, very similar to what is done in SQ
mnoah1
approved these changes
Jun 17, 2026
behinddwalls
force-pushed
the
preetam/api-base-proto
branch
from
1dfcad4 to
6731318
Compare
Collaborator
Author
|
This PR could not be automatically rebased after its base PR was merged. The rebase hit conflicts that need manual resolution. To fix manually: git fetch origin
git checkout preetam/stovepipe-gw-ingest-proto
git rebase --onto origin/main d3e0a48a56f44d928321563515799cde786ca4b5 preetam/stovepipe-gw-ingest-proto
# resolve conflicts, then:
git push --force-with-leaseThen update this PR's base branch: gh pr edit 262 --base main |
## Summary
### Why?
Stovepipe verifies commits that are already on trunk (post-merge/post-submit build and test), but its gateway only exposed Ping. It needs an intake RPC, analogous to SubmitQueue's Land, where a client hands in a trunk commit and gets back a tracking id while verification runs asynchronously.
### What?
Adds the `Ingest` RPC to the Stovepipe gateway proto contract (proto-only; controller and server wiring follow separately):
- `IngestRequest{ queue, change }` and `IngestResponse{ spid }`, where `spid` is the "stovepipe id" handle for tracking the request lifecycle (mirroring Land's `sqid`).
- `change` reuses the shared `uber.base.change.Change` wire type from the parent PR; for git, callers pass a `git://<remote>/<repo>/<ref>/<commit_sha>` commit URI. Unlike Land there is no merge strategy, since the commit is already on trunk.
## Test Plan
- ✅ `make proto`
- ✅ `./tool/bazel build //...`
- ✅ `make test`
Co-authored-by: Cursor <cursoragent@cursor.com>
behinddwalls
force-pushed
the
preetam/stovepipe-gw-ingest-proto
branch
from
40602a0 to
5bb2355
Compare
behinddwalls
temporarily deployed
to
stack-rebase
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
Stovepipe verifies commits that are already on trunk (post-merge/post-submit build and test), but its gateway only exposed Ping. It needs an intake RPC, analogous to SubmitQueue's Land, where a client hands in a trunk commit and gets back a tracking id while verification runs asynchronously.
What?
Adds the
IngestRPC to the Stovepipe gateway proto contract (proto-only; controller and server wiring follow separately):IngestRequest{ queue, change }andIngestResponse{ spid }, wherespidis the "stovepipe id" handle for tracking the request lifecycle (mirroring Land'ssqid).changereuses the shareduber.base.change.Changewire type from the parent PR; for git, callers pass agit://<remote>/<repo>/<ref>/<commit_sha>commit URI. Unlike Land there is no merge strategy, since the commit is already on trunk.Test Plan
make proto./tool/bazel build //...make testStack