Add permanently_remove support to project delete#1110
Merged
Conversation
msrouchou
requested review from
louis-z
and removed request for
a team and
louis-z
Exposes the permanently_remove and full_path query parameters on IProjectClient.DeleteAsync, matching the GitLab API behavior where v18+ soft-deletes by default and requires an explicit flag to bypass the grace period. https://docs.gitlab.com/api/projects/#delete-a-project
louis-z
force-pushed
the
feature/project-permanently-remove
branch
from
bc5b29c to
065b10c
Compare
louis-z
requested changes
Jun 30, 2026
- Rename test method to DeleteAsync_WhenProjectExists_MarksProjectForDeletion - Add comment explaining the mock sets MarkedForDeletionOn to UtcNow - Clarify soft-delete setup steps in tests (required by GitLab before permanently_remove) - Use Utils.AddParameter for full_path query param (consistent with permanently_remove) - Add PermanentlyDeleteAsync wrapper that handles the two-step sequence internally, re-fetching PathWithNamespace after soft-delete to account for GitLab renaming the project Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the
permanently_removeandfull_pathquery parameters onIProjectClient.DeleteAsync,matching the GitLab API behavior where v18+ soft-deletes by default and requires an explicit flag to bypass the grace period.https://docs.gitlab.com/api/projects/#delete-a-project