Skip to content

Implements parameters for RepositoryClient.GetArchive#659

Merged
louis-z merged 8 commits into
ubisoft:mainfrom
steve85:implements-getarchive-params
Jun 30, 2026
Merged

Implements parameters for RepositoryClient.GetArchive#659
louis-z merged 8 commits into
ubisoft:mainfrom
steve85:implements-getarchive-params

Conversation

@steve85

@steve85 steve85 commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

Implements the format, path and sha options for RepositoryClient.GetArchive().

https://docs.gitlab.com/ee/api/repositories.html#get-file-archive

Allows us to retrieve the archive for a particular SHA/ref and specify the required download format.

@steve85 steve85 requested a review from a team as a code owner April 11, 2024 04:56
@steve85 steve85 requested review from louis-z and removed request for a team April 11, 2024 04:56
Comment thread NGitLab/IRepositoryClient.cs Outdated
Comment thread NGitLab/Models/FileArchiveFormat.cs
Comment thread NGitLab/Extensions/TypeExtensions.cs Outdated
@steve85 steve85 requested a review from louis-z April 12, 2024 03:04
@steve85 steve85 changed the title Implements SHA and Format parameters for RepositoryClient.GetArchive Implements parameters for RepositoryClient.GetArchive Apr 12, 2024
@steve85 steve85 force-pushed the implements-getarchive-params branch from 93889b4 to 359668b Compare April 15, 2024 02:14
@steve85

steve85 commented Apr 18, 2024

Copy link
Copy Markdown
Contributor Author

@louis-z can this PR now be merged or are there further outstanding changes you'd like me to make?

@louis-z

louis-z commented Jun 15, 2026

Copy link
Copy Markdown
Member

@steve85, this PR is stale. Is there a plan to resurrect it any time soon? If not, we'll consider closing it.

@steve85 steve85 force-pushed the implements-getarchive-params branch from 359668b to 309ce90 Compare June 17, 2026 05:51
@steve85

steve85 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Hi @louis-z - I was originally waiting on a follow up review from you, hence the lack of activity on this.

I have rebased the branch and made some changes to fix some minor things. Please take a look and let me know if there are any further issues that need addressing.

Comment thread NGitLab.Tests/Impl/UtilsTests.cs Outdated
@louis-z

louis-z commented Jun 22, 2026

Copy link
Copy Markdown
Member

Hi @louis-z - I was originally waiting on a follow up review from you, hence the lack of activity on this.

I have rebased the branch and made some changes to fix some minor things. Please take a look and let me know if there are any further issues that need addressing.

I wrote a comment back in 2024 but forgot to submit it... 🙄 Sorry about that.

It's this one.

Comment thread NGitLab/Models/FileArchiveFormat.cs Outdated
Comment thread NGitLab/Impl/Utils.cs Outdated
Comment thread NGitLab/Impl/Utils.cs Outdated
Comment thread NGitLab.Tests/Impl/UtilsTests.cs Outdated
@steve85 steve85 force-pushed the implements-getarchive-params branch from adb18c4 to be79730 Compare June 23, 2026 11:06
@steve85 steve85 requested a review from louis-z June 23, 2026 12:04
@steve85 steve85 force-pushed the implements-getarchive-params branch from be79730 to 301f853 Compare June 23, 2026 23:26
@steve85

steve85 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

@louis-z - I made the requested changes last week. Can you please review these changes and let me know if there is anything else required?

@louis-z louis-z merged commit d6ed893 into ubisoft:main Jun 30, 2026
7 checks passed
@steve85 steve85 deleted the implements-getarchive-params branch June 30, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants