Repository navigation
LV - v2.2 release - Downloading default log file is not named correctly #165
Description
When viewing the default Plex Media Server.log file in Log Viewer and you click on 'download selected logfile', the file name of said log file is saved as 'Plex' with no file extension.
The same applies for any file name containing a space, only the first word is used for the file name.
WT is installed on Synology NAS. I will test the PC install later on when I have time and report back.
Activity
[-]LV - Downloading default log file is not named correctly[/-][+]LV v2.2 release - Downloading default log file is not named correctly[/+][-]LV v2.2 release - Downloading default log file is not named correctly[/-][+]LV - v2.2 release - Downloading default log file is not named correctly[/+]dagalufh commentedon Apr 26, 2016
I have a suspision that this might be on my end, not sure but i'll check it out.
ukdtom commentedon May 6, 2016
Working fine here
trumpy81 commentedon May 6, 2016
I checked this behaviour in IE, Edge and Chrome and I don't have any issues with them, but in FireFox I do, see the attached image. Same behaviour for both Synology and PC installs of PMS and WebTools.
Could be the mime type in FireFox perhaps??
..
ukdtom commentedon May 6, 2016
Confirmed this to be a Firefox issue only......
Seen the same thing using that :-(
/T
dagalufh commentedon May 6, 2016
Have a theory for fix, i'll see if i have time tonight to test it.
Den 6 maj 2016 03:24 skrev "Tommy Mikkelsen" notifications@github.com:
dagalufh commentedon May 17, 2016
Fix included in next release...
V2.3 DEV:
ukdtom commentedon May 26, 2016
Sadly not fixed, still see this
dagalufh commentedon May 27, 2016
Is it only the default that is not available for download or is it any of the logfiles?
ukdtom commentedon May 27, 2016
All of them.
And they are all avail, so maybe you are missing the point here:
When a log to download contains a space in it's name, the proposed filename to save get's cut of at the space.
Like "Plex Media Server.log" is saved as "Plex"
dagalufh commentedon May 27, 2016
Can you please right click on the element, select box, and do an inspect and show me, via screenshot or something, what it looks like in the code?
It should look something like this:
ukdtom commentedon May 27, 2016
Above taken in Mozilla firefox, and sadly looks okay, so guess it's the function call to save, that behaves differently in firefox
dagalufh commentedon May 27, 2016
Hmm. Can we use some other form of delimiter for space? That you can than
translate to space? Any ideas? How about using + (plus sign)? That is not
usdd in any filenames. Or perhaps / one forward slash?
Den 27 maj 2016 8:06 em skrev "Tommy Mikkelsen" notifications@github.com:
Trying to fix #165
ukdtom commentedon May 27, 2016
Heh.....It's in my end!
Hopefully fixed in c20c8f2
Found this:
http://kb.mozillazine.org/Filenames_with_spaces_are_truncated_upon_download
Updated my branch with a fix, hopefully, and did check with both Chrome, IE11, Edge and Firefox, but would like a confirmation from you @trumpy81 if possible?
Grab my branch to test it, and maybe also FindMedia ;-)
@dagalufh Do note that I also updated logviewer.js with additional logging ;-)
/T
trumpy81 commentedon May 27, 2016
There is also an issue of Firefox 46.0.1 downloading the file as a PDF instead of a text file, although that may be caused by my extremely slow net connection, I was barely able to load this page, so I will have to wait until 1st June when I get unlimited download and no throttling.
Until then I am pretty much offline :(
I do see where the issue appears to be part of the mime type definition, so that may also correct the PDF issue, I will test it as soon as I can.
ukdtom commentedon Jun 25, 2016
@trumpy81 Got better Internet Access now?
trumpy81 commentedon Jun 25, 2016
Yes I have thanks. :)
I did report my findings to you, but I completely forgot about this GHI, sorry about that.
Using the 2.3 Dev version, I have no issues with missing/incorrect file names or incorrect filetypes when using Firefox 47.0. :)
ukdtom commentedon Jun 25, 2016
Thanks