Skip to content

[subtitles] add a download button for sidecar subtitles #181

Closed

Description

@OttoKerner

Please add the possibility to download sidecar subtitles.
Reasoning: Automatically downloaded subtitles are hidden in the obfuscated mess that is the plex data folder. For a normal user to find the right subtitle file in here is next to impossible (or at least very tedious).

If you now try to get ahold of this subtitle file to edit it or to move it beside the video file on your laptop you use in the countryside where there is not internet, you have a hard time.

Maybe, in stage 2, you could opt to move the file automatically beside the video file and, after checking it was successfully copied ;-) remove it from the Plex data folder.
Some users may prefer this method.

Activity

  1. ukdtom commented on May 19, 2016

    @ukdtom
    Owner

    But if we move it, agent will re-download it again, so that part will not work, or?

  2. OttoKerner commented on May 19, 2016

    @OttoKerner
    Author

    But if we move it, agent will re-download it again, so that part will not work, or?

    As I understand it, the agent will only re-download subtitles if the movie is refreshed. I may be wrong though.
    But even if so, the first option is still very desirable.

  3. added this to the milestone on May 19, 2016
  4. ukdtom commented on May 19, 2016

    @ukdtom
    Owner

    We need to make a download button for both agent based and sidecars.
    First we need to make a backend function for this :-(

  5. assigned and unassigned on May 19, 2016
  6. added a commit that references this issue on Jun 26, 2016
  7. ukdtom commented on Jun 26, 2016

    @ukdtom
    Owner

    Framework updated with c6d1712

    See the doc under "Download Subtitle"

  8. assigned and unassigned on Jun 26, 2016
  9. modified the milestones: V2.4, on Oct 22, 2016
  10. 3 remaining items

  11. ukdtom commented on Jan 22, 2017

    @ukdtom
    Owner

    Tested okay by me.

    @OttoKerner What you had in mind here?

    Ohhh....and while at it, please also look into #243

    Download my work branch for a test
    https://github.com/ukdtom/WebTools.bundle/archive/tommy-work.zip

  12. ukdtom commented on Jan 22, 2017

    @ukdtom
    Owner

    @creoludifico Please see comments for #245

    Sorry

  13. added a commit that references this issue on Jan 22, 2017
    796b806
  14. creoludifico commented on Jan 22, 2017

    @creoludifico

    Now possible to download if it's agent sub

  15. OttoKerner commented on Jan 25, 2017

    @OttoKerner
    Author

    Download is working for me. 👍
    Page navigation as well.

  16. ukdtom commented on Jan 25, 2017

    @ukdtom
    Owner

    Thanks Otto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions