Skip to content

Exclude aegistechnologies.com from website link checks - #364

Merged
glenn-jocher merged 1 commit into
mainfrom
exclude-aegistechnologies
Oct 6, 2026
Merged

glenn-jocher merged 1 commit into
mainfrom
exclude-aegistechnologies

Conversation

@nastijakh

@nastijakh nastijakh commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Trade-off: CI can't verify links on this domain either way, since the 418 block happens before the page is served.

🤖 Generated with Claude Code

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Added aegistechnologies.com to the website link-check exclusions so GitHub Actions does not flag its runner-blocked response as a broken link.

📊 Key Changes

  • Updated the protected-domain exclusion regex in the links.yml workflow.
  • Added the same exclusion to both link-check commands in links_local.yml to keep their settings aligned.
  • The exclusion matches the domain and its subdomains.

🎯 Purpose & Impact

  • Link checks skip URLs on this domain, so they will not flag the cited blog URL as broken; they also cannot verify whether links to the domain are valid.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

All Contributors have signed the CLA. ✅

@UltralyticsAssistant UltralyticsAssistant added the devops GitHub Devops or MLops label Oct 6, 2026
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @nastijakh, thank you for submitting a ultralytics/docs 🚀 PR! This automated message confirms your contribution was received, and an Ultralytics engineer will assist with the review. To ensure a seamless integration of your work, please review the following checklist:

  • ✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • ✅ Synchronize with Source: Confirm your PR is synchronized with the ultralytics/docs main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • ✅ Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • ✅ Update Documentation: Update the relevant documentation for any new or modified features.
  • ✅ Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • ✅ Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR; the CLA check will comment with signing instructions if needed.
  • ✅ Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Reviewed the three lychee exclusion lists in links.yml and links_local.yml. The domain pattern is added consistently and preserves the existing boundary matching. LGTM.

@nastijakh

Copy link
Copy Markdown
Collaborator Author

I have read the CLA Document and I sign the CLA

@glenn-jocher
glenn-jocher merged commit 4995844 into main Oct 6, 2026
6 of 8 checks passed
@glenn-jocher
glenn-jocher deleted the exclude-aegistechnologies branch October 6, 2026 12:06
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🎉 PR #364 has been merged—thank you, @nastijakh! The aegistechnologies.com exclusion is now consistent across hosted and local link checks, so runner-blocked responses from that domain won’t be flagged as broken. Links to the domain will also remain unchecked.

“Well done is better than well said.” — Benjamin Franklin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops GitHub Devops or MLops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants