Skip to content

Use setup-uv defaults for Python and the venv - #366

Merged
glenn-jocher merged 3 commits into
mainfrom
setup-uv-defaults
Oct 6, 2026
Merged

glenn-jocher merged 3 commits into
mainfrom
setup-uv-defaults

Conversation

@glenn-jocher

@glenn-jocher glenn-jocher commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Replaces actions/setup-python with ultralytics/actions/setup-uv. By default, that action now activates a venv on the newest Python preinstalled on the runner, with no Python download. Packages install into that venv, so --system is dropped. Jobs that pin a Python version keep the pin on setup-uv, which uses the preinstalled copy when the runner has one.

CI first ran against the setup-uv-defaults branch of ultralytics/actions#915. #915 is now merged (da5463a, released as 0.4.0), so setup-uv is back on @main, which carries the new defaults.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

The links and tag workflows now use setup-uv for Python environment setup and install packages into its activated virtual environment.

📊 Key Changes

  • Removed actions/setup-python steps from the links and tag workflows.
  • Dropped --system from uv pip install commands for requirements, codespell, and ultralytics-actions.
  • Updated the workflows to use ultralytics/actions/setup-uv@main.

🎯 Purpose & Impact

  • Dependency installs in these workflows now target the setup-uv virtual environment instead of system Python; no user-facing change.

@UltralyticsAssistant UltralyticsAssistant added the devops GitHub Devops or MLops label Oct 6, 2026
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/docs 🚀 PR! This automated message confirms your contribution was received, and an Ultralytics engineer will assist with the review. To ensure a seamless integration of your work, please review the following checklist:

  • ✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • ✅ Synchronize with Source: Confirm your PR is synchronized with the ultralytics/docs main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • ✅ Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • ✅ Update Documentation: Update the relevant documentation for any new or modified features.
  • ✅ Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • ✅ Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR; the CLA check will comment with signing instructions if needed.
  • ✅ Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Reviewed the Python setup and package-install changes in .github/workflows/links.yml and .github/workflows/tag.yml. The new setup-uv defaults and removal of --system are consistent; LGTM.

@UltralyticsAssistant
UltralyticsAssistant dismissed their stale review October 6, 2026 17:19

Superseded by new review

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review 2

Made with ❤️ by Ultralytics Actions

No code changes since review 1; its LGTM missed that both workflows still use setup-uv@main rather than the validation branch stated in the PR. The tag workflow can fail after pushing the tag, leaving a partial release. Pin both action references to the branch while validating.

💬 Posted 1 inline comment
  • ⚠️ HIGH .github/workflows/tag.yml:67 The workflow above still uses setup-uv@main, not the setup-uv-defaults branch described in the PR. While actions#915 is open, this means the new venv default is not active, so removing --system can make uv pip install fail for lack of an active venv. Because this install runs after the tag is pushed, that can leave a tag published without the release step completing. Pin setup-uv to setup-uv-defaults in both workflows during validation; switch back after #915 merges.

Comment thread .github/workflows/tag.yml

- name: Install dependencies
run: uv pip install --system ultralytics-actions
run: uv pip install ultralytics-actions

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultralytics/actions#915 merged at 17:18 UTC (da5463a, released as 0.4.0), so setup-uv@main now carries the new defaults and this CI run exercises them. The validation commit pointing at @setup-uv-defaults was already reverted, and the PR description is updated to match.

Comment thread .github/workflows/tag.yml

- name: Install dependencies
run: uv pip install --system ultralytics-actions
run: uv pip install ultralytics-actions

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultralytics/actions#915 merged at 17:18 UTC (da5463a, released as 0.4.0), so setup-uv@main now carries the new defaults and this CI run exercises them. The validation commit pointing at @setup-uv-defaults was already reverted, and the PR description is updated to match.

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review 3

Made with ❤️ by Ultralytics Actions

Since review 2, the setup-uv reference concern is resolved: the upstream defaults change has merged, and the PR description reflects that. This diff removes separate Python setup and installs packages into the setup-uv venv in both workflows. No remaining issues; LGTM.

@glenn-jocher
glenn-jocher merged commit b3c469f into main Oct 6, 2026
8 checks passed
@glenn-jocher
glenn-jocher deleted the setup-uv-defaults branch October 6, 2026 17:43
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🎉 PR #366 has been merged—thank you, @glenn-jocher! The links and tag workflows now install dependencies into the setup-uv virtual environment.

“Well done is better than well said.” — Benjamin Franklin

A practical workflow improvement that puts the change into action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops GitHub Devops or MLops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants