Repository navigation
Fix website spellcheck and link-check false positives (GES, Linz, ftc.gov) - #368
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
👋 Hello @nastijakh, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed the website spellcheck ignore-list change in .github/workflows/links.yml. Adding GES and Linz to the existing codespell list addresses the reported false positives without changing workflow behavior otherwise. LGTM.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 2
Made with ❤️ by Ultralytics Actions
Since review 1, the FTC-domain exclusion has been added consistently to all three lychee calls. The GES/Linz spellcheck fix remains intact; no behavioral issues found. LGTM.
|
🎉 PR #368 has been merged! Thank you @nastijakh, with contributions from @glenn-jocher.
These updates help website checks recognize |
Fixes false positives in the scheduled "Website links and spellcheck" Slack alerts for www.ultralytics.com.
Spelling
Two correct terms on glossary pages are flagged:
GES==> GOES, GUESS on /glossary/causal-discovery: Greedy Equivalence Search, a standard causal discovery algorithm.Linz==> Lines on /glossary/frechet-inception-distance-fid: Johannes Kepler University Linz, where FID was introduced.This job runs codespell with its own
--ignore-words-listinlinks.yml, separate from theultralytics/actionslist. ultralytics/actions#920 added these words there, which only covers PR formatting checks, so the website alert kept firing. Verified locally: codespell flags both words with the old list and passes with the new one.Broken links
5 ftc.gov / consumer.ftc.gov links on blog and glossary pages are reported as 404. They load fine in a browser; ftc.gov returns 403/404 to non-browser clients, even with a browser User-Agent. Adds
ftc\.govto the shared bot-protected-domain--excluderegex next tofda\.gov, kept in sync across all three lychee calls (links.yml+ 2×links_local.yml). The regex covers subdomains, so it includesconsumer.ftc.gov.🤖 Generated with Claude Code
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated the website checks to recognize
GESandLinzas valid spelling and exclude FTC domains that return errors to the link checker.📊 Key Changes
GESandLinzto the spellcheck ignore list in the website links workflow.ftc.govto the link-check exclusion pattern in the main workflow and both local link-check calls; the pattern also covers subdomains such asconsumer.ftc.gov.🎯 Purpose & Impact