Skip to content

Fix website spellcheck and link-check false positives (GES, Linz, ftc.gov) - #368

Merged
glenn-jocher merged 2 commits into
mainfrom
codespell-ignore-ges-linz
Oct 9, 2026
Merged

glenn-jocher merged 2 commits into
mainfrom
codespell-ignore-ges-linz

Conversation

@nastijakh

@nastijakh nastijakh commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes false positives in the scheduled "Website links and spellcheck" Slack alerts for www.ultralytics.com.

Spelling

Two correct terms on glossary pages are flagged:

  • GES ==> GOES, GUESS on /glossary/causal-discovery: Greedy Equivalence Search, a standard causal discovery algorithm.
  • Linz ==> Lines on /glossary/frechet-inception-distance-fid: Johannes Kepler University Linz, where FID was introduced.

This job runs codespell with its own --ignore-words-list in links.yml, separate from the ultralytics/actions list. ultralytics/actions#920 added these words there, which only covers PR formatting checks, so the website alert kept firing. Verified locally: codespell flags both words with the old list and passes with the new one.

Broken links

5 ftc.gov / consumer.ftc.gov links on blog and glossary pages are reported as 404. They load fine in a browser; ftc.gov returns 403/404 to non-browser clients, even with a browser User-Agent. Adds ftc\.gov to the shared bot-protected-domain --exclude regex next to fda\.gov, kept in sync across all three lychee calls (links.yml + 2× links_local.yml). The regex covers subdomains, so it includes consumer.ftc.gov.

🤖 Generated with Claude Code

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Updated the website checks to recognize GES and Linz as valid spelling and exclude FTC domains that return errors to the link checker.

📊 Key Changes

  • Added GES and Linz to the spellcheck ignore list in the website links workflow.
  • Added ftc.gov to the link-check exclusion pattern in the main workflow and both local link-check calls; the pattern also covers subdomains such as consumer.ftc.gov.

🎯 Purpose & Impact

  • The scheduled website checks no longer flag these glossary terms as misspellings or report excluded FTC URLs as broken links. FTC URLs are not checked by those link-check calls.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@UltralyticsAssistant UltralyticsAssistant added the devops GitHub Devops or MLops label Oct 9, 2026
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @nastijakh, thank you for submitting a ultralytics/docs 🚀 PR! This automated message confirms your contribution was received, and an Ultralytics engineer will assist with the review. To ensure a seamless integration of your work, please review the following checklist:

  • ✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • ✅ Synchronize with Source: Confirm your PR is synchronized with the ultralytics/docs main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • ✅ Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • ✅ Update Documentation: Update the relevant documentation for any new or modified features.
  • ✅ Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • ✅ Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR; the CLA check will comment with signing instructions if needed.
  • ✅ Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Reviewed the website spellcheck ignore-list change in .github/workflows/links.yml. Adding GES and Linz to the existing codespell list addresses the reported false positives without changing workflow behavior otherwise. LGTM.

@nastijakh
nastijakh requested a review from glenn-jocher October 9, 2026 09:54
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nastijakh nastijakh changed the title Add GES and Linz to website spellcheck ignore list Fix website spellcheck and link-check false positives (GES, Linz, ftc.gov) Oct 9, 2026
@UltralyticsAssistant
UltralyticsAssistant dismissed their stale review October 9, 2026 09:59

Superseded by new review

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review 2

Made with ❤️ by Ultralytics Actions

Since review 1, the FTC-domain exclusion has been added consistently to all three lychee calls. The GES/Linz spellcheck fix remains intact; no behavioral issues found. LGTM.

@glenn-jocher
glenn-jocher merged commit 2ae84e6 into main Oct 9, 2026
7 of 8 checks passed
@glenn-jocher
glenn-jocher deleted the codespell-ignore-ges-linz branch October 9, 2026 11:30
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🎉 PR #368 has been merged! Thank you @nastijakh, with contributions from @glenn-jocher.

“Alone we can do so little; together we can do so much.” — Helen Keller

These updates help website checks recognize GES and Linz and skip FTC domains that return errors to the link checker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops GitHub Devops or MLops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants