Skip to content

Suppress Slack notifications on workflow reruns - #107

Merged
glenn-jocher merged 1 commit into
mainfrom
fix/slack-reruns
Oct 9, 2026
Merged

glenn-jocher merged 1 commit into
mainfrom
fix/slack-reruns

Conversation

@glenn-jocher

@glenn-jocher glenn-jocher commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Workflow re-runs could send duplicate Slack notifications. Restrict the existing notification owner to the first run attempt, covering both success and failure while preserving the work performed by retries.

Validation: parsed the changed YAML, checked the diff, and compared actionlint results with the base; no new diagnostics.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

The publish workflow’s notification job now runs only on the first attempt, preventing duplicate Slack notifications from reruns.

📊 Key Changes

  • Added a github.run_attempt == '1' condition to the notify job.
  • Kept the existing always() and increment-output conditions.

🎯 Purpose & Impact

  • Reruns can still perform the workflow’s other work, but the notification job is skipped after the first attempt, for both successful and failed reruns.

@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops fixed Bug has been resolved labels Oct 9, 2026
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/template 🚀 PR! This automated message confirms your contribution was received, and an Ultralytics engineer will assist with the review. To ensure a seamless integration of your work, please review the following checklist:

  • ✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • ✅ Synchronize with Source: Confirm your PR is synchronized with the ultralytics/template main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • ✅ Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • ✅ Update Documentation: Update the relevant documentation for any new or modified features.
  • ✅ Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • ✅ Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR; the CLA check will comment with signing instructions if needed.
  • ✅ Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Reviewed the publish workflow notification gate and its success/failure steps. The attempt-1 condition suppresses Slack notifications on reruns without skipping the retry jobs. LGTM.

@glenn-jocher
glenn-jocher merged commit b0c0da3 into main Oct 9, 2026
15 checks passed
@glenn-jocher
glenn-jocher deleted the fix/slack-reruns branch October 9, 2026 15:07
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🎉 PR #107 was merged—thank you, @glenn-jocher! The first-attempt check keeps reruns from sending duplicate Slack notifications.

“Great things are done by a series of small things brought together.” — Vincent van Gogh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops GitHub Devops or MLops fixed Bug has been resolved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants