Repository navigation
Suppress Slack notifications on workflow reruns - #107
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed the publish workflow notification gate and its success/failure steps. The attempt-1 condition suppresses Slack notifications on reruns without skipping the retry jobs. LGTM.
|
🎉 PR #107 was merged—thank you, @glenn-jocher! The first-attempt check keeps reruns from sending duplicate Slack notifications.
|
Workflow re-runs could send duplicate Slack notifications. Restrict the existing notification owner to the first run attempt, covering both success and failure while preserving the work performed by retries.
Validation: parsed the changed YAML, checked the diff, and compared actionlint results with the base; no new diagnostics.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
The publish workflow’s notification job now runs only on the first attempt, preventing duplicate Slack notifications from reruns.
📊 Key Changes
github.run_attempt == '1'condition to thenotifyjob.always()and increment-output conditions.🎯 Purpose & Impact