Repository navigation
Conversation
|
@ghazy2001 is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
[High impact] The PR appears safe to merge; all four previous findings are addressed. SummaryAdds a page-size picker to data tables and passes the selected size through paged queries.
All four previous findings are addressed. No new actionable issues were established. Tests and browser checks were not run.
|
ghazy2001
force-pushed
the
feat/data-tables-page-size-picker
branch
from
November 1, 2026 17:48
41007e3 to
efb506d
Compare
ghazy2001
force-pushed
the
feat/data-tables-page-size-picker
branch
from
November 1, 2026 17:53
efb506d to
a44c6fa
Compare
…y and error filters
Author
|
@greptile review Addressed all 4 review findings:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a page-size picker across Umami's data tables and pager component, resolving part of #4102 and addressing the maintainer suggestion from PR #4118 ("a page-size picker would be welcome as a smaller PR on top of that").
Changes
PAGE_SIZE_OPTIONS = [10, 20, 50, 100]insrc/lib/constants.ts.rows-per-page("Rows per page") inpublic/intl/messages/en-US.jsonand registeredrowsPerPageinsrc/components/messages.ts.Pager: Added optionalonPageSizeChangeandpageSizeOptionsprops. When provided, renders a clean<Select>dropdown next to page navigation while ensuring non-standard existing page sizes remain selectable.DataGrid: EnabledallowPageSizeby default, updating router query params (page: 1, pageSize) upon selection.usePagedQuery: AddedpageSizeto query key and query parameters so queries properly re-fetch when page size changes.src/components/common/Pager.test.tsx(8 tests covering rendering, page size changes, edge cases, and disabled states).src/components/hooks/usePagedQuery.test.ts(2 tests verifyingpageSizepropagation to TanStack Query).Verification
pnpm exec biome check: Passed with 0 errors.pnpm exec vitest run src/components/common/Pager.test.tsx src/components/hooks/usePagedQuery.test.ts: 10/10 passed.Need help on this PR? Tag
@codesmith-botwith what you need.