fix(crawler): await dispatcher stream aclose in arun_many#2089
Open
Solaris-star wants to merge 1 commit into
Open
fix(crawler): await dispatcher stream aclose in arun_many#2089Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
Hold an explicit reference to run_urls_stream and always aclose() it in the public generator's finally block so dispatcher-owned crawl tasks are cancelled and awaited before proxy-session release. Fixes unclecode#2083.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#2072 made
MemoryAdaptiveDispatcher.run_urls_stream()clean up when that generator is closed. The public API pathAsyncWebCrawler.arun_many(..., stream=True)still only wrapped it in anasync for+ proxy-session release, so earlyaclose()on the public generator could release the session while dispatcher-owned tasks were still running.Change
await stream_gen.aclose()infinallybefore proxy-session auto-releaseTest plan
tests/async/test_dispatchers.py) remain the unit-level guarantee for the underlying generatorasync for+ early generator close onarun_many(..., stream=True)should no longer leave crawl tasks aliveFixes #2083.