Skip to content

Port Char16TrieBuilder to pure Rust and use it in datagen #8549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
robertbastian wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Port Char16TrieBuilder to pure Rust and use it in datagen #8549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7eaee71
cursor
robertbastian Oct 6, 2026
7111f0c
iter2
robertbastian Oct 6, 2026
47d0cdc
zerotrie
robertbastian Oct 6, 2026
00e0faa
port
robertbastian Oct 6, 2026
20687ea
use txt
robertbastian Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

260 changes: 108 additions & 152 deletions components/collator/src/elements.rs
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions components/collator/src/provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
// Provider structs must be stable
#![allow(clippy::exhaustive_structs, clippy::exhaustive_enums)]

use icu_collections::char16trie::Char16TrieIterator;
use icu_collections::char16trie::Char16TrieCursor;
use icu_collections::codepointtrie::CodePointTrie;
use icu_provider::prelude::*;
use zerovec::ZeroVec;
Expand Down Expand Up @@ -267,9 +267,9 @@ impl<'data> CollationData<'data> {
pub(crate) fn get_default_and_trie(
&'data self,
index: usize,
) -> (CollationElement32, Char16TrieIterator<'data>) {
) -> (CollationElement32, Char16TrieCursor<'data>) {
let (ce32, trie) = self.get_default_and_trie_impl(index);
(ce32, Char16TrieIterator::new(trie))
(ce32, Char16TrieCursor::new(trie))
}
pub(crate) fn get_default(&'data self, index: usize) -> CollationElement32 {
let (ce32, _) = self.get_default_and_trie_impl(index);
Expand Down
Loading
Loading